From 2ef5b138ee306f9df099d4ea795b15dea3d43aa7 Mon Sep 17 00:00:00 2001 From: Ali Mohammad Pur Date: Fri, 23 Apr 2021 03:32:37 +0430 Subject: [PATCH] LibJS: Use the match's global offset for 'index' in RegExp.exec() This was not noticed before because all the previous matches were single-line. --- Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp b/Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp index d4b7861219..182d7a00fb 100644 --- a/Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp +++ b/Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp @@ -168,7 +168,7 @@ JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::exec) // FIXME: Do code point index correction if the Unicode flag is set. auto* array = Array::create(global_object); array->indexed_properties().set_array_like_size(result.n_capture_groups + 1); - array->define_property(vm.names.index, Value((i32)match.column)); + array->define_property(vm.names.index, Value((i32)match.global_offset)); array->define_property(vm.names.input, js_string(vm, str)); array->indexed_properties().put(array, 0, js_string(vm, match.view.to_string()));