From 2f1d596dd379c9c3e66bb5fef00d875b126d86b7 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 6 Aug 2020 11:45:02 +0200 Subject: [PATCH] UserspaceEmulator: Fix bad rc check in ttyname and getcwd syscalls Errors here are (rc < 0), not (rc < 1). --- DevTools/UserspaceEmulator/Emulator.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DevTools/UserspaceEmulator/Emulator.cpp b/DevTools/UserspaceEmulator/Emulator.cpp index 6330c8b5a2..a506030d79 100644 --- a/DevTools/UserspaceEmulator/Emulator.cpp +++ b/DevTools/UserspaceEmulator/Emulator.cpp @@ -1271,7 +1271,7 @@ int Emulator::virt$ttyname(int fd, FlatPtr buffer, size_t buffer_size) { auto host_buffer = ByteBuffer::create_zeroed(buffer_size); int rc = syscall(SC_ttyname, fd, host_buffer.data(), host_buffer.size()); - if (rc < 1) + if (rc < 0) return rc; mmu().copy_to_vm(buffer, host_buffer.data(), host_buffer.size()); return rc; @@ -1281,7 +1281,7 @@ int Emulator::virt$getcwd(FlatPtr buffer, size_t buffer_size) { auto host_buffer = ByteBuffer::create_zeroed(buffer_size); int rc = syscall(SC_getcwd, host_buffer.data(), host_buffer.size()); - if (rc < 1) + if (rc < 0) return rc; mmu().copy_to_vm(buffer, host_buffer.data(), host_buffer.size()); return rc;