RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 15:48:12 +00:00
Code Issues Activity Actions

AK: Make MappedFile heap-allocated and ref-counted

Browse source 
Let's adapt this class a bit better to how it's actually being used.

Instead of having valid/invalid states and storing an error in case
it's invalid, a MappedFile is now always valid, and the factory
function that creates it will return an OSError if mapping fails.
This commit is contained in:
Andreas Kling 2021-01-10 15:55:54 +01:00
parent 70fce5c4c7
commit 2f3b901f7f
36 changed files with 184 additions and 199 deletions
Download patch file Download diff file Expand all files Collapse all files

32
AK/MappedFile.h
View file

@ -27,37 +27,33 @@
#pragma once
#include <AK/Noncopyable.h>
#include <AK/StringView.h>
#include <AK/NonnullRefPtr.h>
#include <AK/OSError.h>
#include <AK/RefCounted.h>
#include <AK/Result.h>
namespace AK {
class MappedFile {
class MappedFile : public RefCounted<MappedFile> {
AK_MAKE_NONCOPYABLE(MappedFile);
AK_MAKE_NONMOVABLE(MappedFile);
public:
MappedFile() { }
explicit MappedFile(const StringView& file_name);
MappedFile(MappedFile&&);
static Result<NonnullRefPtr<MappedFile>, OSError> map(const StringView& path);
~MappedFile();
MappedFile& operator=(MappedFile&&);
void* data() { return m_data; }
const void* data() const { return m_data; }
bool is_valid() const { return m_map != (void*)-1; }
int errno_if_invalid() const
{
ASSERT(!is_valid());
return m_errno;
}
void unmap();
void* data() { return m_map; }
const void* data() const { return m_map; }
size_t size() const { return m_size; }
ReadonlyBytes bytes() const { return { m_data, m_size }; }
private:
explicit MappedFile(void*, size_t);
void* m_data { nullptr };
size_t m_size { 0 };
void* m_map { (void*)-1 };
int m_errno { 0 };
};
}