From 2f754013a19663e422c74f1e41dbdb5eaf6ef486 Mon Sep 17 00:00:00 2001 From: Tom Date: Sat, 17 Jul 2021 21:36:20 -0600 Subject: [PATCH] LibGUI: Fix widgets not being occluded Widget::is_visible_for_timer_purposes needs to also consult with the base implementation, which ultimately checks the owning Window's visibility and occlusion state. Widget::is_visible merely determins whether a widget should be visible or not, regardless of the window's state. Fixes #8825 --- Userland/Libraries/LibGUI/Widget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibGUI/Widget.cpp b/Userland/Libraries/LibGUI/Widget.cpp index 8765a97d2c..e69eb1209b 100644 --- a/Userland/Libraries/LibGUI/Widget.cpp +++ b/Userland/Libraries/LibGUI/Widget.cpp @@ -1135,7 +1135,7 @@ bool Widget::has_pending_drop() const bool Widget::is_visible_for_timer_purposes() const { - return is_visible(); + return is_visible() && Object::is_visible_for_timer_purposes(); } }