From 2f79d0e8b9888fc3dd35db119d3a951373a7ac58 Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Tue, 4 Apr 2023 14:11:38 +0300 Subject: [PATCH] Kernel: Mark sys$mprotect as not needing the big lock All accesses to shared mutable data are already serialized behind the process address space spinlock. --- Kernel/API/Syscall.h | 2 +- Kernel/Syscalls/mmap.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/API/Syscall.h b/Kernel/API/Syscall.h index 2a90d2900d..3b91d57c03 100644 --- a/Kernel/API/Syscall.h +++ b/Kernel/API/Syscall.h @@ -127,7 +127,7 @@ enum class NeedsBigProcessLock { S(mknod, NeedsBigProcessLock::No) \ S(mmap, NeedsBigProcessLock::No) \ S(mount, NeedsBigProcessLock::Yes) \ - S(mprotect, NeedsBigProcessLock::Yes) \ + S(mprotect, NeedsBigProcessLock::No) \ S(mremap, NeedsBigProcessLock::Yes) \ S(msync, NeedsBigProcessLock::Yes) \ S(munmap, NeedsBigProcessLock::Yes) \ diff --git a/Kernel/Syscalls/mmap.cpp b/Kernel/Syscalls/mmap.cpp index f55cbc5ecc..31b84f3ccc 100644 --- a/Kernel/Syscalls/mmap.cpp +++ b/Kernel/Syscalls/mmap.cpp @@ -268,7 +268,7 @@ ErrorOr Process::sys$mmap(Userspace use ErrorOr Process::sys$mprotect(Userspace addr, size_t size, int prot) { - VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this); + VERIFY_NO_PROCESS_BIG_LOCK(this); TRY(require_promise(Pledge::stdio)); if (prot & PROT_EXEC) {