RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-30 10:12:07 +00:00
Code Issues Activity Actions

LibWeb: Implement resolved style for line-height

Browse source
This commit is contained in:
Sam Atkins 2023-09-29 12:47:20 +01:00 • committed by Sam Atkins
parent 30e31d83b6
commit 2fa1df2ec4
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp
View file

@ -177,8 +177,14 @@ RefPtr<StyleValue const> ResolvedCSSStyleDeclaration::style_value_for_property(L
case PropertyID::TextDecorationColor: case PropertyID::TextDecorationColor:
return ColorStyleValue::create(layout_node.computed_values().text_decoration_color()); return ColorStyleValue::create(layout_node.computed_values().text_decoration_color());
// FIXME: -> line-height // -> line-height
// The resolved value is normal if the computed value is normal, or the used value otherwise. // The resolved value is normal if the computed value is normal, or the used value otherwise.
case PropertyID::LineHeight: {
auto line_height = static_cast<DOM::Element const&>(*layout_node.dom_node()).computed_css_values()->property(property_id);
if (line_height->is_identifier() && line_height->to_identifier() == ValueID::Normal)
return line_height;
return LengthStyleValue::create(Length::make_px(layout_node.line_height()));
}
// FIXME: -> block-size // FIXME: -> block-size
// -> height // -> height