RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:47:35 +00:00
Code Issues Activity Actions

BindingsGenerator: Use JS::Value::to_string() when new String

Browse source 
Make sure to use JS::Value::to_string() when the IDL interface is marked
with the extended attribute UseNewAKString.
This commit is contained in:
Kenneth Myhra 2023-02-25 10:24:54 +01:00 • committed by Linus Groh
parent 99f094905e
commit 2facb0e8ed
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -1226,9 +1226,15 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
if (includes_string) {
// 14. If types includes a string type, then return the result of converting V to that type.
// NOTE: Currently all string types are converted to String.
union_generator.append(R"~~~(
if (interface.extended_attributes.contains("UseNewAKString")) {
union_generator.append(R"~~~(
return TRY(@js_name@@js_suffix@.to_string(vm));
)~~~");
} else {
union_generator.append(R"~~~(
return TRY(@js_name@@js_suffix@.to_deprecated_string(vm));
)~~~");
}
} else if (numeric_type && includes_bigint) {
// 15. If types includes a numeric type and bigint, then return the result of converting V to either that numeric type or bigint.
// https://webidl.spec.whatwg.org/#converted-to-a-numeric-type-or-bigint