RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 22:08:10 +00:00
Code Issues Activity Actions

Kernel+LibC: Add O_EXEC, move exec permission checking to VFS::open()

Browse source 
O_EXEC is mentioned by POSIX, so let's have it. Currently, it is only used
inside the kernel to ensure the process has the right permissions when opening
an executable.
This commit is contained in:
Sergey Bugaev 2020-01-11 18:33:35 +03:00 • committed by Andreas Kling
parent 4566c2d811
commit 2fcbb846fb
4 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/FileSystem/VirtualFileSystem.cpp
View file

@ -215,6 +215,10 @@ KResultOr<NonnullRefPtr<FileDescription>> VFS::open(StringView path, int options
return KResult(-EISDIR);
should_truncate_file = options & O_TRUNC;
}
if (options & O_EXEC) {
if (!metadata.may_execute(current->process()))
return KResult(-EACCES);
}
if (metadata.is_device()) {
auto device = Device::get_device(metadata.major_device, metadata.minor_device);

1
Kernel/FileSystem/VirtualFileSystem.h
View file

@ -15,6 +15,7 @@
#define O_RDONLY 0
#define O_WRONLY 1
#define O_RDWR 2
#define O_EXEC 4
#define O_CREAT 0100
#define O_EXCL 0200
#define O_NOCTTY 0400

5
Kernel/Process.cpp
View file

@ -653,15 +653,12 @@ int Process::do_exec(String path, Vector<String> arguments, Vector<String> envir
if (parts.is_empty())
return -ENOENT;
auto result = VFS::the().open(path, 0, 0, current_directory());
auto result = VFS::the().open(path, O_EXEC, 0, current_directory());
if (result.is_error())
return result.error();
auto description = result.value();
auto metadata = description->metadata();
if (!metadata.may_execute(*this))
return -EACCES;
if (!metadata.size)
return -ENOTIMPL;

1
Libraries/LibC/fcntl.h
View file

@ -17,6 +17,7 @@ __BEGIN_DECLS
#define O_WRONLY 1
#define O_RDWR 2
#define O_ACCMODE 3
#define O_EXEC 4
#define O_CREAT 0100
#define O_EXCL 0200
#define O_NOCTTY 0400