RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:48:12 +00:00
Code Issues Activity Actions

Ladybird/Everywhere: Ensure that Qt objects are created with parents

Browse source 
This prevents memory leaks detected by both Valgrind and ASAN/LSAN.

Valgrind is still suspicious of the leaked JS::VM from
Web::Bindings::main_thread_vm() but there's other issues with leak
checking all the GC'd objects.

Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
This commit is contained in:
Andrew Kaster 2022-10-01 12:46:24 -06:00
parent f9af2832c8
commit 2ff37d7e13
7 changed files with 41 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/SettingsDialog.cpp
View file

@ -14,11 +14,11 @@ extern Browser::Settings* s_settings;
SettingsDialog::SettingsDialog(QMainWindow* window)
: m_window(window)
{
m_layout = new QFormLayout;
m_homepage = new QLineEdit;
m_ok_button = new QPushButton("&Save");
m_layout = new QFormLayout(this);
m_homepage = new QLineEdit(this);
m_ok_button = new QPushButton("&Save", this);
m_layout->addWidget(new QLabel("Homepage"));
m_layout->addWidget(new QLabel("Homepage", this));
m_layout->addWidget(m_homepage);
m_layout->addWidget(m_ok_button);