RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

Ladybird/Everywhere: Ensure that Qt objects are created with parents

Browse source 
This prevents memory leaks detected by both Valgrind and ASAN/LSAN.

Valgrind is still suspicious of the leaked JS::VM from
Web::Bindings::main_thread_vm() but there's other issues with leak
checking all the GC'd objects.

Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
This commit is contained in:
Andrew Kaster 2022-10-01 12:46:24 -06:00
parent f9af2832c8
commit 2ff37d7e13
7 changed files with 41 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Ladybird/Tab.cpp
View file

@ -19,15 +19,16 @@ extern String s_serenity_resource_root;
extern Browser::Settings* s_settings;
Tab::Tab(BrowserWindow* window)
: m_window(window)
: QWidget(window)
, m_window(window)
{
m_layout = new QBoxLayout(QBoxLayout::Direction::TopToBottom, this);
m_layout->setSpacing(0);
m_layout->setContentsMargins(0, 0, 0, 0);
m_view = new SimpleWebView;
m_toolbar = new QToolBar;
m_location_edit = new QLineEdit;
m_toolbar = new QToolBar(this);
m_location_edit = new QLineEdit(this);
m_hover_label = new QLabel(this);
m_hover_label->hide();