RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:37:45 +00:00
Code Issues Activity Actions

LibJS: Don't return empty value from PromiseReactionJob::call(), for now

Browse source
This commit is contained in:
Linus Groh 2021-10-15 01:08:02 +01:00
parent fb85fd4867
commit 2ffb30a996
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/PromiseJobs.cpp
View file

@ -53,7 +53,9 @@ Value PromiseReactionJob::call()
if (!promise_capability.has_value()) { if (!promise_capability.has_value()) {
dbgln_if(PROMISE_DEBUG, "[PromiseReactionJob @ {}]: Reaction has no PromiseCapability, returning empty value", this); dbgln_if(PROMISE_DEBUG, "[PromiseReactionJob @ {}]: Reaction has no PromiseCapability, returning empty value", this);
return {}; // TODO: This can't return an empty value at the moment, because the implicit conversion to Completion would fail.
// Change it back when this is using completions (`return normal_completion({})`)
return js_undefined();
} }
if (vm.exception()) { if (vm.exception()) {