RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

Kernel: Make it possible for KBufferBuilder creation to fail

Browse source 
This patch adds KBufferBuilder::try_create() and treats it like anything
else that can fail. And so, failure to allocate the initial internal
buffer of the builder will now propagate an ENOMEM to the caller. :^)
This commit is contained in:
Andreas Kling 2021-09-07 15:54:23 +02:00
parent be613b9ef6
commit 300402cc14
9 changed files with 30 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/ProcessExposed.cpp
View file

@ -144,7 +144,7 @@ KResult ProcFSGlobalInformation::refresh_data(OpenFileDescription& description)
if (!cached_data)
return ENOMEM;
}
KBufferBuilder builder;
auto builder = TRY(KBufferBuilder::try_create());
TRY(const_cast<ProcFSGlobalInformation&>(*this).try_generate(builder));
auto& typed_cached_data = static_cast<ProcFSInodeData&>(*cached_data);
typed_cached_data.buffer = builder.build();
@ -157,7 +157,7 @@ KResultOr<size_t> ProcFSExposedLink::read_bytes(off_t offset, size_t count, User
{
VERIFY(offset == 0);
MutexLocker locker(m_lock);
KBufferBuilder builder;
auto builder = TRY(KBufferBuilder::try_create());
if (!const_cast<ProcFSExposedLink&>(*this).acquire_link(builder))
return KResult(EFAULT);
auto blob = builder.build();