From 300711d0135b9f7f6b416a49dd0595825e05e12c Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Fri, 18 Jun 2021 13:57:27 +0200 Subject: [PATCH] WindowServer: Preserve all members in MouseEvent::translated() We were forgetting to preserve the m_drag and m_mime_data members of WindowServer::MouseEvent when making a translated copy. This didn't affect any reachable code paths before this change. --- Userland/Services/WindowServer/Event.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Userland/Services/WindowServer/Event.h b/Userland/Services/WindowServer/Event.h index 7e0d217c65..20b3568d4d 100644 --- a/Userland/Services/WindowServer/Event.h +++ b/Userland/Services/WindowServer/Event.h @@ -117,7 +117,12 @@ public: void set_drag(bool b) { m_drag = b; } void set_mime_data(const Core::MimeData& mime_data) { m_mime_data = mime_data; } - MouseEvent translated(const Gfx::IntPoint& delta) const { return MouseEvent((Type)type(), m_position.translated(delta), m_buttons, m_button, m_modifiers, m_wheel_delta); } + MouseEvent translated(Gfx::IntPoint const& delta) const + { + MouseEvent event = *this; + event.m_position = m_position.translated(delta); + return event; + } private: Gfx::IntPoint m_position;