1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 02:28:12 +00:00

LibJS: Implement Temporal.Duration.prototype.years

This commit is contained in:
Linus Groh 2021-07-15 23:34:53 +01:00
parent 23766f28db
commit 300a22f9b9
4 changed files with 48 additions and 1 deletions

View file

@ -352,7 +352,8 @@ namespace JS {
P(valueOf) \
P(values) \
P(warn) \
P(writable)
P(writable) \
P(years)
struct CommonPropertyNames {
PropertyName and_ { "and", PropertyName::StringMayBeNumber::No };

View file

@ -5,6 +5,7 @@
*/
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/Temporal/Duration.h>
#include <LibJS/Runtime/Temporal/DurationPrototype.h>
namespace JS::Temporal {
@ -23,6 +24,34 @@ void DurationPrototype::initialize(GlobalObject& global_object)
// 7.3.2 Temporal.Duration.prototype[ @@toStringTag ], https://tc39.es/proposal-temporal/#sec-temporal.duration.prototype-@@tostringtag
define_direct_property(*vm.well_known_symbol_to_string_tag(), js_string(vm.heap(), "Temporal.Duration"), Attribute::Configurable);
define_native_accessor(vm.names.years, years_getter, {}, Attribute::Configurable);
}
static Duration* typed_this(GlobalObject& global_object)
{
auto& vm = global_object.vm();
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return {};
if (!is<Duration>(this_object)) {
vm.throw_exception<TypeError>(global_object, ErrorType::NotA, "Temporal.Duration");
return {};
}
return static_cast<Duration*>(this_object);
}
// 7.3.3 get Temporal.Duration.prototype.years, https://tc39.es/proposal-temporal/#sec-get-temporal.duration.prototype.years
JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::years_getter)
{
// 1. Let duration be the this value.
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto* duration = typed_this(global_object);
if (vm.exception())
return {};
// 3. Return duration.[[Years]].
return Value(duration->years());
}
}

View file

@ -17,6 +17,9 @@ public:
explicit DurationPrototype(GlobalObject&);
virtual void initialize(GlobalObject&) override;
virtual ~DurationPrototype() override = default;
private:
JS_DECLARE_NATIVE_FUNCTION(years_getter);
};
}

View file

@ -0,0 +1,14 @@
describe("correct behavior", () => {
test("basic functionality", () => {
const duration = new Temporal.Duration(123);
expect(duration.years).toBe(123);
});
});
test("errors", () => {
test("this value must be a Temporal.Duration object", () => {
expect(() => {
Reflect.get(Temporal.Duration.prototype, "years", "foo");
}).toThrowWithMessage(TypeError, "Not a Temporal.Duration");
});
});