RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 14:35:07 +00:00
Code Issues Activity Actions

LibWeb: Fire the change event synchronously when committing changes

Browse source 
The spec does not say to do this asynchronously on a task queue.
This commit is contained in:
Timothy Flynn 2023-12-03 08:21:58 -05:00 • committed by Andreas Kling
parent b749167506
commit 301d58e2d9
2 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Tests/LibWeb/Text/input/input-commit.html
View file

@ -1,12 +1,11 @@
<input id=input type=text> <input id=input type=text>
<script src="include.js"></script> <script src="include.js"></script>
<script> <script>
asyncTest((done) => { test(() => {
let input = document.getElementById("input"); let input = document.getElementById("input");
input.addEventListener("change", () => { input.addEventListener("change", () => {
println(input.value); println(input.value);
done();
}); });
internals.sendText(input, "wfh :^)"); internals.sendText(input, "wfh :^)");

6
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -433,10 +433,8 @@ void HTMLInputElement::commit_pending_changes()
m_has_uncommitted_changes = false; m_has_uncommitted_changes = false;
queue_an_element_task(HTML::Task::Source::UserInteraction, [this] { auto change_event = DOM::Event::create(realm(), HTML::EventNames::change, { .bubbles = true });
auto change_event = DOM::Event::create(realm(), HTML::EventNames::change, { .bubbles = true }); dispatch_event(change_event);
dispatch_event(change_event);
});
} }
void HTMLInputElement::update_placeholder_visibility() void HTMLInputElement::update_placeholder_visibility()