RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:07:44 +00:00
Code Issues Activity Actions

AudioApplet: Make the slider exponential for finer volume control

Browse source 
The volume slider was linear, which is not ideal for an audio volume 
control. Perceived volume would not change much within 30-100% range
and would change in leaps within 0-30% range where the resolution is
not sufficient for fine grained control.

The simplest solution is to bring the value into 0.0-1.0 range and 
square it to obtain an exponential curve. This is a decent 
approximation of the logarithmic taper used in audio potentiometers.
This commit is contained in:
Marcin Gasperowicz 2020-10-14 17:37:15 +02:00 • committed by Andreas Kling
parent 5245277369
commit 3039c36836
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
MenuApplets/Audio/main.cpp
View file

@ -108,7 +108,8 @@ public:
m_slider->set_size_policy(GUI::SizePolicy::Fill, GUI::SizePolicy::Fill); m_slider->set_size_policy(GUI::SizePolicy::Fill, GUI::SizePolicy::Fill);
m_slider->on_value_changed = [&](int value) { m_slider->on_value_changed = [&](int value) {
int volume = clamp((20 - value) * 5, 0, 100); int volume = clamp((20 - value) * 5, 0, 100);
m_audio_client->set_main_mix_volume(volume); float volume_log = ((volume / 100.0f) * (volume / 100.0f)) * 100.0f;
m_audio_client->set_main_mix_volume(volume_log);
update(); update();
}; };
@ -147,7 +148,8 @@ private:
if (m_audio_muted) if (m_audio_muted)
return; return;
int volume = clamp(m_audio_volume - event.wheel_delta() * 5, 0, 100); int volume = clamp(m_audio_volume - event.wheel_delta() * 5, 0, 100);
m_audio_client->set_main_mix_volume(volume); float volume_log = ((volume / 100.0f) * (volume / 100.0f)) * 100.0f;
m_audio_client->set_main_mix_volume(volume_log);
m_slider->set_value(20 - (volume / 5)); m_slider->set_value(20 - (volume / 5));
update(); update();
} }