RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:07:34 +00:00
Code Issues Activity Actions

LibJS+LibWeb: Move native properties to separate getters/setters

Browse source 
This was a bit cumbersome now, but it gets us closer to a format suited
for code generation.
This commit is contained in:
Andreas Kling 2020-03-29 00:37:33 +01:00
parent 56936b97d0
commit 30440134cb
19 changed files with 210 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Libraries/LibWeb/Bindings/ElementWrapper.cpp
View file

@ -26,6 +26,7 @@
#include <AK/FlyString.h>
#include <AK/Function.h>
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/PrimitiveString.h>
#include <LibJS/Runtime/Value.h>
#include <LibWeb/Bindings/ElementWrapper.h>
@ -37,14 +38,7 @@ namespace Bindings {
ElementWrapper::ElementWrapper(Element& element)
: NodeWrapper(element)
{
put_native_property(
"innerHTML",
[this](JS::Object*) {
return JS::js_string(heap(), node().inner_html());
},
[this](JS::Object*, JS::Value value) {
node().set_inner_html(value.to_string());
});
put_native_property("innerHTML", inner_html_getter, inner_html_setter);
}
ElementWrapper::~ElementWrapper()
@ -61,5 +55,27 @@ const Element& ElementWrapper::node() const
return static_cast<const Element&>(NodeWrapper::node());
}
static Element* impl_from(JS::Interpreter& interpreter)
{
auto* this_object = interpreter.this_value().to_object(interpreter.heap());
if (!this_object)
return nullptr;
// FIXME: Verify that it's an ElementWrapper somehow!
return &static_cast<ElementWrapper*>(this_object)->node();
}
JS::Value ElementWrapper::inner_html_getter(JS::Interpreter& interpreter)
{
if (auto* impl = impl_from(interpreter))
return JS::js_string(interpreter.heap(), impl->inner_html());
return {};
}
void ElementWrapper::inner_html_setter(JS::Interpreter& interpreter, JS::Value value)
{
if (auto* impl = impl_from(interpreter))
impl->set_inner_html(value.to_string());
}
}
}