RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-23 18:45:07 +00:00
Code Issues Activity Actions

LibWeb: Until an image has loaded or failed, don't occupy layout size

Browse source 
This patch makes images have an implicit zero intrinsic size before
they have either loaded or failed to load. This is tracked by the
ImageLoader object.

This fixes a long-standing issue with images occupying empty 150x150
rectangles of space.
This commit is contained in:
Andreas Kling 2020-08-12 13:47:55 +02:00
parent bd54854c64
commit 305e2ef69c
3 changed files with 33 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/Loader/ImageLoader.cpp
View file

@ -39,6 +39,7 @@ ImageLoader::ImageLoader()
void ImageLoader::load(const URL& url)
{
m_loading_state = LoadingState::Loading;
LoadRequest request;
request.set_url(url);
set_resource(ResourceLoader::the().load_resource(Resource::Type::Image, request));
@ -62,11 +63,14 @@ void ImageLoader::resource_did_load()
ASSERT(resource());
if (!resource()->mime_type().starts_with("image/")) {
m_loading_state = LoadingState::Failed;
if (on_fail)
on_fail();
return;
}
m_loading_state = LoadingState::Loaded;
#ifdef IMAGE_LOADER_DEBUG
if (!resource()->has_encoded_data()) {
dbg() << "ImageLoader: Resource did load, no encoded data. URL: " << resource()->url();
@ -118,6 +122,7 @@ void ImageLoader::animate()
void ImageLoader::resource_did_fail()
{
dbg() << "ImageLoader: Resource did fail. URL: " << resource()->url();
m_loading_state = LoadingState::Failed;
if (on_fail)
on_fail();
}