From 3078572f0dec0d507ea0ae1f7d371c8f56933008 Mon Sep 17 00:00:00 2001 From: Andrew Kaster Date: Mon, 5 Feb 2024 04:22:03 -0700 Subject: [PATCH] Meta: Disable misc-include-cleaner in clang-tidy IncludeCleaner is a new feature of clang-tidy/clangd that adds upstream support for the include-what-you-use (IWYU) tool's checks. However, this tool is very noisy on our codebase. It can be enabled by individual contributors at their leisure. --- .clang-tidy | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index cf2cb5858d..e2d022cb82 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -8,6 +8,7 @@ # cert-dcl51-cpp: Alias for bugprone-reserved-identifier # cert-dcl21-cpp: No reference to this rule exists on Carnegie Mellon's SEI CERT C++ Confluence. And the suggestion is unusual # misc-no-recursion: The project uses recursive algorithms in several places. +# misc-include-cleaner: This check is nice for cleanliness, but is very very noisy # FIXME: misc-non-private-member-variables-in-classes: Audit uses of protected member variables to see if they really need to be protected # performance-noexcept-move-constructor: The project does not use exceptions, so there are no such optimizations available # performance-no-int-to-ptr: This rule flags every pointer to integer cast, which gets quite noisy. Should only be enabled on a case-by-case basis @@ -30,6 +31,7 @@ Checks: > -bugprone-macro-parentheses, -bugprone-reserved-identifier,-cert-dcl37-c,-cert-dcl51-cpp, -cert-dcl21-cpp, + -misc-include-cleaner, -misc-no-recursion, -misc-non-private-member-variables-in-classes, -misc-use-anonymous-namespace,