From 30842916254ed5981299d739b7a2003c97857763 Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Sat, 20 Feb 2021 23:30:21 +0100 Subject: [PATCH] LibGUI: Fix crash when previewing palette images For example, navigating File Manager to a directory that contains a vaild BMP file that uses a palette, this code would end up trying to create an indexed thumbnail. However, Painter asserts that the thumbnail that we paint on is *not* indexed, usually crashing File Manager. Partially fixes #5299, as it now crashes somewhere else. --- Userland/Libraries/LibGUI/FileSystemModel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibGUI/FileSystemModel.cpp b/Userland/Libraries/LibGUI/FileSystemModel.cpp index f38bc0116b..4c8d7b08af 100644 --- a/Userland/Libraries/LibGUI/FileSystemModel.cpp +++ b/Userland/Libraries/LibGUI/FileSystemModel.cpp @@ -497,7 +497,7 @@ static RefPtr render_thumbnail(const StringView& path) double scale = min(32 / (double)png_bitmap->width(), 32 / (double)png_bitmap->height()); - auto thumbnail = Gfx::Bitmap::create(png_bitmap->format(), { 32, 32 }); + auto thumbnail = Gfx::Bitmap::create(Gfx::BitmapFormat::RGBA32, { 32, 32 }); Gfx::IntRect destination = Gfx::IntRect(0, 0, (int)(png_bitmap->width() * scale), (int)(png_bitmap->height() * scale)); destination.center_within(thumbnail->rect());