RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:47:35 +00:00
Code Issues Activity Actions

LibPDF: Implement two SeparationColorSpace methods

Browse source 
Actually using separation color spaces still doesn't work, but we
now no longer assert on them when they're used.

Fixes 2 crashes on the `-n 500` 0000.zip pdfa dataset.
This commit is contained in:
Nico Weber 2023-10-24 10:39:58 -07:00 • committed by Andreas Kling
parent 2311e28d63
commit 311cc7d9b9
2 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibPDF/ColorSpace.cpp
View file

@ -396,8 +396,7 @@ PDFErrorOr<Color> SeparationColorSpace::color(ReadonlySpan<Value>) const
Vector<float> SeparationColorSpace::default_decode() const Vector<float> SeparationColorSpace::default_decode() const
{ {
warnln("PDF: TODO implement SeparationColorSpace::default_decode()"); return { 0.0f, 1.0f };
return {};
} }
} }

2
Userland/Libraries/LibPDF/ColorSpace.h
View file

@ -151,7 +151,7 @@ public:
~SeparationColorSpace() override = default; ~SeparationColorSpace() override = default;
PDFErrorOr<Color> color(ReadonlySpan<Value> arguments) const override; PDFErrorOr<Color> color(ReadonlySpan<Value> arguments) const override;
int number_of_components() const override { TODO(); } int number_of_components() const override { return 1; }
Vector<float> default_decode() const override; Vector<float> default_decode() const override;
ColorSpaceFamily const& family() const override { return ColorSpaceFamily::Separation; } ColorSpaceFamily const& family() const override { return ColorSpaceFamily::Separation; }