RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:42:43 +00:00
Code Issues Activity Actions

LibGfx: Fix classic theme frame transparency check

Browse source 
We shouldn't use the title stripe or title shadow colors to determine
whether the frame itself is going to have alpha channels or not. This
caused e.g. the classic theme's window frame to be rendered as
transparency just because the stripe color had an alpha channel of 0.
This commit is contained in:
Tom 2021-07-04 10:25:14 -06:00 • committed by Andreas Kling
parent 8c14488106
commit 31a2f10927
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibGfx/ClassicWindowTheme.h
View file

@ -47,7 +47,10 @@ private:
bool uses_alpha() const
{
return title_color.alpha() != 0xff || border_color.alpha() != 0xff || border_color2.alpha() != 0xff || title_stripes_color.alpha() != 0xff || title_shadow_color.alpha() != 0xff;
// We don't care about the title_stripes_color or title_shadow_color alpha channels because they are
// effectively rendered on top of the borders and don't mean whether the frame itself atually has
// any alpha channels that would require the entire frame to be rendered as transparency.
return title_color.alpha() != 0xff || border_color.alpha() != 0xff || border_color2.alpha() != 0xff;
}
};