RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:27:44 +00:00
Code Issues Activity Actions

LibJS: Avoid transitions for name/length of native functions/accessors

Browse source
This commit is contained in:
Linus Groh 2021-08-28 17:37:00 +01:00
parent 8bcda353a2
commit 31bc9565f8
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -1023,15 +1023,15 @@ void Object::define_native_accessor(PropertyName const& property_name, Function<
if (getter) { if (getter) {
auto name = String::formatted("get {}", formatted_property_name); auto name = String::formatted("get {}", formatted_property_name);
getter_function = NativeFunction::create(global_object(), name, move(getter)); getter_function = NativeFunction::create(global_object(), name, move(getter));
getter_function->define_direct_property(vm.names.length, Value(0), Attribute::Configurable); getter_function->define_direct_property_without_transition(vm.names.length, Value(0), Attribute::Configurable);
getter_function->define_direct_property(vm.names.name, js_string(vm, name), Attribute::Configurable); getter_function->define_direct_property_without_transition(vm.names.name, js_string(vm, name), Attribute::Configurable);
} }
FunctionObject* setter_function = nullptr; FunctionObject* setter_function = nullptr;
if (setter) { if (setter) {
auto name = String::formatted("set {}", formatted_property_name); auto name = String::formatted("set {}", formatted_property_name);
setter_function = NativeFunction::create(global_object(), name, move(setter)); setter_function = NativeFunction::create(global_object(), name, move(setter));
setter_function->define_direct_property(vm.names.length, Value(1), Attribute::Configurable); setter_function->define_direct_property_without_transition(vm.names.length, Value(1), Attribute::Configurable);
setter_function->define_direct_property(vm.names.name, js_string(vm, name), Attribute::Configurable); setter_function->define_direct_property_without_transition(vm.names.name, js_string(vm, name), Attribute::Configurable);
} }
return define_direct_accessor(property_name, getter_function, setter_function, attribute); return define_direct_accessor(property_name, getter_function, setter_function, attribute);
} }
@ -1096,8 +1096,8 @@ void Object::define_native_function(PropertyName const& property_name, Function<
function_name = String::formatted("[{}]", property_name.as_symbol()->description()); function_name = String::formatted("[{}]", property_name.as_symbol()->description());
} }
auto* function = NativeFunction::create(global_object(), function_name, move(native_function)); auto* function = NativeFunction::create(global_object(), function_name, move(native_function));
function->define_direct_property(vm.names.length, Value(length), Attribute::Configurable); function->define_direct_property_without_transition(vm.names.length, Value(length), Attribute::Configurable);
function->define_direct_property(vm.names.name, js_string(vm, function_name), Attribute::Configurable); function->define_direct_property_without_transition(vm.names.name, js_string(vm, function_name), Attribute::Configurable);
define_direct_property(property_name, function, attribute); define_direct_property(property_name, function, attribute);
} }