1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:37:47 +00:00

LibJS: Disallow negative set record sizes

This is a normative change in the Set Methods proposal. See:
4155e6e
This commit is contained in:
Timothy Flynn 2023-07-18 07:00:14 -04:00 committed by Linus Groh
parent ac124fbaae
commit 31e555aaa5
8 changed files with 65 additions and 5 deletions

View file

@ -229,21 +229,25 @@ static ThrowCompletionOr<SetRecord> get_set_record(VM& vm, Value value)
// 6. Let intSize be ! ToIntegerOrInfinity(numSize).
auto integer_size = MUST(number_size.to_integer_or_infinity(vm));
// 7. Let has be ? Get(obj, "has").
// 7. If intSize < 0, throw a RangeError exception.
if (integer_size < 0)
return vm.throw_completion<RangeError>(ErrorType::NumberIsNegative, "size"sv);
// 8. Let has be ? Get(obj, "has").
auto has = TRY(object.get(vm.names.has));
// 8. If IsCallable(has) is false, throw a TypeError exception.
// 9. If IsCallable(has) is false, throw a TypeError exception.
if (!has.is_function())
return vm.throw_completion<TypeError>(ErrorType::NotAFunction, TRY_OR_THROW_OOM(vm, has.to_string_without_side_effects()));
// 9. Let keys be ? Get(obj, "keys").
// 10. Let keys be ? Get(obj, "keys").
auto keys = TRY(object.get(vm.names.keys));
// 10. If IsCallable(keys) is false, throw a TypeError exception.
// 11. If IsCallable(keys) is false, throw a TypeError exception.
if (!keys.is_function())
return vm.throw_completion<TypeError>(ErrorType::NotAFunction, TRY_OR_THROW_OOM(vm, keys.to_string_without_side_effects()));
// 11. Return a new Set Record { [[Set]]: obj, [[Size]]: intSize, [[Has]]: has, [[Keys]]: keys }.
// 12. Return a new Set Record { [[Set]]: obj, [[Size]]: intSize, [[Has]]: has, [[Keys]]: keys }.
return SetRecord { .set = object, .size = integer_size, .has = has.as_function(), .keys = keys.as_function() };
}

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().difference({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.difference).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().intersection({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.intersection).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().isDisjointFrom({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.isDisjointFrom).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().isSubsetOf({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.isSubsetOf).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().isSupersetOf({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.isSupersetOf).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().symmetricDifference({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.symmetricDifference).toHaveLength(1);

View file

@ -1,3 +1,11 @@
describe("errors", () => {
test("called with negative size", () => {
expect(() => {
new Set().union({ size: -1 });
}).toThrowWithMessage(RangeError, "size must not be negative");
});
});
test("basic functionality", () => {
expect(Set.prototype.union).toHaveLength(1);