RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:37:46 +00:00
Code Issues Activity Actions

LibJS: Fix types of PlainDateTime iso_{milli,micro,nano}second params

Browse source 
999 does not fit into an u8. :^)
This commit is contained in:
Linus Groh 2021-07-28 18:31:32 +01:00
parent 2ba338869b
commit 321f2c0927
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTime.cpp
View file

@ -15,7 +15,7 @@
namespace JS::Temporal { namespace JS::Temporal {
// 5 Temporal.PlainDateTime Objects, https://tc39.es/proposal-temporal/#sec-temporal-plaindatetime-objects // 5 Temporal.PlainDateTime Objects, https://tc39.es/proposal-temporal/#sec-temporal-plaindatetime-objects
PlainDateTime::PlainDateTime(i32 iso_year, u8 iso_month, u8 iso_day, u8 iso_hour, u8 iso_minute, u8 iso_second, u8 iso_millisecond, u8 iso_microsecond, u8 iso_nanosecond, Object& calendar, Object& prototype) PlainDateTime::PlainDateTime(i32 iso_year, u8 iso_month, u8 iso_day, u8 iso_hour, u8 iso_minute, u8 iso_second, u16 iso_millisecond, u16 iso_microsecond, u16 iso_nanosecond, Object& calendar, Object& prototype)
: Object(prototype) : Object(prototype)
, m_iso_year(iso_year) , m_iso_year(iso_year)
, m_iso_month(iso_month) , m_iso_month(iso_month)

2
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTime.h
View file

@ -16,7 +16,7 @@ class PlainDateTime final : public Object {
JS_OBJECT(PlainDateTime, Object); JS_OBJECT(PlainDateTime, Object);
public: public:
PlainDateTime(i32 iso_year, u8 iso_month, u8 iso_day, u8 iso_hour, u8 iso_minute, u8 iso_second, u8 iso_millisecond, u8 iso_microsecond, u8 iso_nanosecond, Object& calendar, Object& prototype); PlainDateTime(i32 iso_year, u8 iso_month, u8 iso_day, u8 iso_hour, u8 iso_minute, u8 iso_second, u16 iso_millisecond, u16 iso_microsecond, u16 iso_nanosecond, Object& calendar, Object& prototype);
virtual ~PlainDateTime() override = default; virtual ~PlainDateTime() override = default;
[[nodiscard]] i32 iso_year() const { return m_iso_year; } [[nodiscard]] i32 iso_year() const { return m_iso_year; }

4
Userland/Libraries/LibJS/Tests/builtins/Temporal/PlainDateTime/PlainDateTime.prototype.getISOFields.js
View file

@ -22,11 +22,11 @@ describe("normal behavior", () => {
calendar: calendar, calendar: calendar,
isoDay: 23, isoDay: 23,
isoHour: 0, isoHour: 0,
isoMicrosecond: 200, isoMicrosecond: 456,
isoMillisecond: 123, isoMillisecond: 123,
isoMinute: 42, isoMinute: 42,
isoMonth: 7, isoMonth: 7,
isoNanosecond: 21, isoNanosecond: 789,
isoSecond: 18, isoSecond: 18,
isoYear: 2021, isoYear: 2021,
}); });