RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:37:46 +00:00
Code Issues Activity Actions

LibWeb/HTML: Propagate OOM errors from Window::{local,session}_storage()

Browse source 
This requires a bit of error type conversion glue as HashMap::try_ensure
expects the callback to return ErrorOr<T> like the function itself does.
This commit is contained in:
Linus Groh 2023-03-11 18:06:11 +00:00
parent 4da68384e6
commit 324dacbc5d
3 changed files with 24 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -258,8 +258,8 @@ void ConnectionFromClient::debug_request(DeprecatedString const& request, Deprec
}
if (request == "dump-local-storage") {
if (auto* doc = page().top_level_browsing_context().active_document())
doc->window().local_storage()->dump();
if (auto* document = page().top_level_browsing_context().active_document())
document->window().local_storage().release_value_but_fixme_should_propagate_errors()->dump();
}
}
@ -549,14 +549,14 @@ void ConnectionFromClient::set_window_size(Gfx::IntSize size)
Messages::WebContentServer::GetLocalStorageEntriesResponse ConnectionFromClient::get_local_storage_entries()
{
auto* document = page().top_level_browsing_context().active_document();
auto local_storage = document->window().local_storage();
auto local_storage = document->window().local_storage().release_value_but_fixme_should_propagate_errors();
return local_storage->map();
}
Messages::WebContentServer::GetSessionStorageEntriesResponse ConnectionFromClient::get_session_storage_entries()
{
auto* document = page().top_level_browsing_context().active_document();
auto session_storage = document->window().session_storage();
auto session_storage = document->window().session_storage().release_value_but_fixme_should_propagate_errors();
return session_storage->map();
}