RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:47:44 +00:00
Code Issues Activity Actions

LibGUI: Fix silly nullptr dereference in MessageBox::show()

Browse source 
Since we take the parent object as a raw pointer, we should handle the
case where it's null.
This commit is contained in:
Andreas Kling 2020-02-24 09:15:51 +01:00
parent 525f8df5b8
commit 3252a6925e
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGUI/MessageBox.cpp
View file

@ -35,7 +35,9 @@ namespace GUI {
int MessageBox::show(const StringView& text, const StringView& title, Type type, InputType input_type, Core::Object* parent) int MessageBox::show(const StringView& text, const StringView& title, Type type, InputType input_type, Core::Object* parent)
{ {
auto box = parent->add<MessageBox>(text, title, type, input_type); auto box = MessageBox::construct(text, title, type, input_type);
if (parent)
parent->add_child(box);
return box->exec(); return box->exec();
} }