RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:57:47 +00:00
Code Issues Activity Actions

LibVideo/VP9: Choose whether/how to show new frames using an enum

Browse source 
There are three mutually exclusive frame-showing states:
- Show no new frame, only store the frame as a reference.
- Show a newly decoded frame.
- Show frame from the reference frame store.
Since they are mutually exclusive, using an enum rather than two bools
makes more sense.
This commit is contained in:
Zaggy1024 2022-11-22 21:36:36 -06:00 • committed by Andreas Kling
parent befcd479ae
commit 3259c99cab
4 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibVideo/VP9/Parser.cpp
View file

@ -104,7 +104,7 @@ DecoderErrorOr<FrameContext> Parser::parse_frame(ReadonlyBytes frame_data)
TRY(refresh_probs());
m_previous_frame_size = frame_context.size();
m_previous_show_frame = m_show_frame;
m_previous_show_frame = frame_context.shows_a_frame();
return frame_context;
}
@ -171,7 +171,8 @@ DecoderErrorOr<FrameContext> Parser::uncompressed_header()
m_last_frame_type = m_frame_type;
m_frame_type = TRY(read_frame_type());
m_show_frame = TRY_READ(m_bit_stream->read_bit());
if (!TRY_READ(m_bit_stream->read_bit()))
frame_context.set_frame_hidden();
m_error_resilient_mode = TRY_READ(m_bit_stream->read_bit());
Gfx::Size<u32> frame_size;
@ -185,7 +186,7 @@ DecoderErrorOr<FrameContext> Parser::uncompressed_header()
m_refresh_frame_flags = 0xFF;
m_frame_is_intra = true;
} else {
m_frame_is_intra = !m_show_frame && TRY_READ(m_bit_stream->read_bit());
m_frame_is_intra = !frame_context.shows_a_frame() && TRY_READ(m_bit_stream->read_bit());
if (!m_error_resilient_mode) {
m_reset_frame_context = TRY_READ(m_bit_stream->read_bits(2));