RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:47:34 +00:00
Code Issues Activity Actions

Kernel: Fix 4-byte uninitialized memory leak in sys$sigaltstack()

Browse source 
It was possible to extract 4 bytes of uninitialized kernel stack memory
on x86_64 by looking in the padding of stack_t.
This commit is contained in:
Andreas Kling 2021-12-17 14:45:09 +01:00
parent ed839450c8
commit 32aa623eff
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Syscalls/sigaction.cpp
View file

@ -262,7 +262,7 @@ ErrorOr<FlatPtr> Process::sys$sigaltstack(Userspace<const stack_t*> user_ss, Use
REQUIRE_PROMISE(sigaction);
if (user_old_ss) {
stack_t old_ss_value;
stack_t old_ss_value {};
old_ss_value.ss_sp = (void*)Thread::current()->m_alternative_signal_stack;
old_ss_value.ss_size = Thread::current()->m_alternative_signal_stack_size;
old_ss_value.ss_flags = 0;