RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:37:35 +00:00
Code Issues Activity Actions

LibWeb: Don't delay document load event forever with cached style sheets

Browse source 
If we try to <link> a stylesheet that was already cached, we'll get a
synchronous resource_did_load() callback. Because of this, it's
necessary to set up the document load event delayer *before* calling
set_resource(), as otherwise we'd be stuck without a load event forever.
This commit is contained in:
Andreas Kling 2022-02-15 14:11:51 +01:00
parent 9f02afd8fe
commit 32b8023ad1
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/HTML/HTMLLinkElement.cpp
View file

@ -33,8 +33,10 @@ void HTMLLinkElement::inserted()
auto url = document().parse_url(href()); auto url = document().parse_url(href());
dbgln_if(CSS_LOADER_DEBUG, "HTMLLinkElement: Loading import URL: {}", url); dbgln_if(CSS_LOADER_DEBUG, "HTMLLinkElement: Loading import URL: {}", url);
auto request = LoadRequest::create_for_url_on_page(url, document().page()); auto request = LoadRequest::create_for_url_on_page(url, document().page());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, request)); // NOTE: Mark this element as delaying the document load event *before* calling set_resource()
// as it may trigger a synchronous resource_did_load() callback.
m_document_load_event_delayer.emplace(document()); m_document_load_event_delayer.emplace(document());
set_resource(ResourceLoader::the().load_resource(Resource::Type::Generic, request));
} }
if (m_relationship & Relationship::Preload) { if (m_relationship & Relationship::Preload) {