RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 21:22:46 +00:00
Code Issues Activity Actions

LibWeb: Add missing visit_edges() for ImageStyleValue

Browse source 
ImageStyleValue has a visit_edges() method, although it is not a
GC-allocated object. This is necessary because it owns a GC-allocated
ImageRequest that we want to visit, instead of using JS::Handle, to
avoid leaks. In the future, we might want to make StyleValue be
GC-allocated.

For now, this change adds missing visit_edges() calls for objects that
own ImageStyleValue.
This commit is contained in:
Aliaksandr Kalenik 2023-09-28 00:26:02 +02:00 • committed by Andreas Kling
parent b43b3d2f8d
commit 32be413f4e
4 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLBodyElement.cpp
View file

@ -22,6 +22,13 @@ HTMLBodyElement::HTMLBodyElement(DOM::Document& document, DOM::QualifiedName qua
HTMLBodyElement::~HTMLBodyElement() = default;
void HTMLBodyElement::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
if (m_background_style_value)
m_background_style_value->visit_edges(visitor);
}
void HTMLBodyElement::initialize(JS::Realm& realm)
{
Base::initialize(realm);