RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:28:12 +00:00
Code Issues Activity Actions

LibWeb: Add missing visit_edges() for ImageStyleValue

Browse source 
ImageStyleValue has a visit_edges() method, although it is not a
GC-allocated object. This is necessary because it owns a GC-allocated
ImageRequest that we want to visit, instead of using JS::Handle, to
avoid leaks. In the future, we might want to make StyleValue be
GC-allocated.

For now, this change adds missing visit_edges() calls for objects that
own ImageStyleValue.
This commit is contained in:
Aliaksandr Kalenik 2023-09-28 00:26:02 +02:00 • committed by Andreas Kling
parent b43b3d2f8d
commit 32be413f4e
4 changed files with 23 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLBodyElement.cpp
View file

@ -22,6 +22,13 @@ HTMLBodyElement::HTMLBodyElement(DOM::Document& document, DOM::QualifiedName qua
HTMLBodyElement::~HTMLBodyElement() = default; HTMLBodyElement::~HTMLBodyElement() = default;
void HTMLBodyElement::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
if (m_background_style_value)
m_background_style_value->visit_edges(visitor);
}
void HTMLBodyElement::initialize(JS::Realm& realm) void HTMLBodyElement::initialize(JS::Realm& realm)
{ {
Base::initialize(realm); Base::initialize(realm);

2
Userland/Libraries/LibWeb/HTML/HTMLBodyElement.h
View file

@ -29,6 +29,8 @@ public:
private: private:
HTMLBodyElement(DOM::Document&, DOM::QualifiedName); HTMLBodyElement(DOM::Document&, DOM::QualifiedName);
virtual void visit_edges(Visitor&) override;
// ^DOM::Node // ^DOM::Node
virtual bool is_html_body_element() const override { return true; } virtual bool is_html_body_element() const override { return true; }

11
Userland/Libraries/LibWeb/Layout/Node.cpp
View file

@ -307,6 +307,17 @@ NodeWithStyle::NodeWithStyle(DOM::Document& document, DOM::Node* node, CSS::Comp
m_font = Platform::FontPlugin::the().default_font(); m_font = Platform::FontPlugin::the().default_font();
} }
void NodeWithStyle::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
for (auto& layer : m_computed_values.background_layers()) {
if (layer.background_image && layer.background_image->is_image())
layer.background_image->as_image().visit_edges(visitor);
}
if (m_list_style_image && m_list_style_image->is_image())
m_list_style_image->as_image().visit_edges(visitor);
}
// https://www.w3.org/TR/css-values-4/#snap-a-length-as-a-border-width // https://www.w3.org/TR/css-values-4/#snap-a-length-as-a-border-width
static CSSPixels snap_a_length_as_a_border_width(double device_pixels_per_css_pixel, CSSPixels length) static CSSPixels snap_a_length_as_a_border_width(double device_pixels_per_css_pixel, CSSPixels length)
{ {

3
Userland/Libraries/LibWeb/Layout/Node.h
View file

@ -15,6 +15,7 @@
#include <LibWeb/CSS/ComputedValues.h> #include <LibWeb/CSS/ComputedValues.h>
#include <LibWeb/CSS/StyleComputer.h> #include <LibWeb/CSS/StyleComputer.h>
#include <LibWeb/CSS/StyleProperties.h> #include <LibWeb/CSS/StyleProperties.h>
#include <LibWeb/CSS/StyleValues/ImageStyleValue.h>
#include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Document.h>
#include <LibWeb/FontCache.h> #include <LibWeb/FontCache.h>
#include <LibWeb/Forward.h> #include <LibWeb/Forward.h>
@ -222,6 +223,8 @@ public:
void transfer_table_box_computed_values_to_wrapper_computed_values(CSS::ComputedValues& wrapper_computed_values); void transfer_table_box_computed_values_to_wrapper_computed_values(CSS::ComputedValues& wrapper_computed_values);
virtual void visit_edges(Cell::Visitor& visitor) override;
protected: protected:
NodeWithStyle(DOM::Document&, DOM::Node*, NonnullRefPtr<CSS::StyleProperties>); NodeWithStyle(DOM::Document&, DOM::Node*, NonnullRefPtr<CSS::StyleProperties>);
NodeWithStyle(DOM::Document&, DOM::Node*, CSS::ComputedValues); NodeWithStyle(DOM::Document&, DOM::Node*, CSS::ComputedValues);