RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-30 05:42:37 +00:00
Code Issues Activity Actions

LibJS: Add String.prototype.toString()

Browse source
This commit is contained in:
Linus Groh 2020-04-10 14:23:01 +01:00 • committed by Andreas Kling
parent 6f3ea75569
commit 32c27afdf0
3 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -48,6 +48,7 @@ StringPrototype::StringPrototype()
put_native_function("indexOf", index_of, 1); put_native_function("indexOf", index_of, 1);
put_native_function("toLowerCase", to_lowercase, 0); put_native_function("toLowerCase", to_lowercase, 0);
put_native_function("toUpperCase", to_uppercase, 0); put_native_function("toUpperCase", to_uppercase, 0);
put_native_function("toString", to_string, 0);
} }
StringPrototype::~StringPrototype() StringPrototype::~StringPrototype()
@ -167,12 +168,18 @@ Value StringPrototype::to_uppercase(Interpreter& interpreter)
Value StringPrototype::length_getter(Interpreter& interpreter) Value StringPrototype::length_getter(Interpreter& interpreter)
{ {
auto* this_object = interpreter.this_value().to_object(interpreter.heap()); auto* string_object = string_object_from(interpreter);
if (!this_object) if (!string_object)
return {}; return {};
if (!this_object->is_string_object()) return Value((i32) string_object->primitive_string()->string().length());
return interpreter.throw_exception<TypeError>("Not a String object"); }
return Value((i32) static_cast<const StringObject*>(this_object)->primitive_string()->string().length());
Value StringPrototype::to_string(Interpreter& interpreter)
{
auto* string_object = string_object_from(interpreter);
if (!string_object)
return {};
return js_string(interpreter, string_object->primitive_string()->string());
} }
} }

1
Libraries/LibJS/Runtime/StringPrototype.h
View file

@ -44,6 +44,7 @@ private:
static Value index_of(Interpreter&); static Value index_of(Interpreter&);
static Value to_lowercase(Interpreter&); static Value to_lowercase(Interpreter&);
static Value to_uppercase(Interpreter&); static Value to_uppercase(Interpreter&);
static Value to_string(Interpreter&);
static Value length_getter(Interpreter&); static Value length_getter(Interpreter&);
}; };

9
Libraries/LibJS/Tests/String.prototype.toString.js Normal file
View file

@ -0,0 +1,9 @@
try {
assert(String.prototype.toString.length === 0)
assert("".toString() === "");
assert("hello friends".toString() === "hello friends");
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}