From 32d142b06cceb8817c4e1a316d3aee282cc7d3a3 Mon Sep 17 00:00:00 2001 From: Idan Horowitz Date: Sat, 2 Apr 2022 00:37:40 +0300 Subject: [PATCH] LibWeb: Remove no-op calls to emit_includes_for_all_imports for headers When called with is_header=true the method was essentailly a no-op. --- .../LibWeb/WrapperGenerator/IDLGenerators.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp b/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp index 8d05d704c1..4c5c8d4989 100644 --- a/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp +++ b/Meta/Lagom/Tools/CodeGenerators/LibWeb/WrapperGenerator/IDLGenerators.cpp @@ -202,12 +202,10 @@ static void generate_include_for(auto& generator, auto& path) )~~~"); } -static void emit_includes_for_all_imports(auto& interface, auto& generator, bool is_header, bool is_iterator = false) +static void emit_includes_for_all_imports(auto& interface, auto& generator, bool is_iterator = false) { Queue const*> interfaces; HashTable paths_imported; - if (is_header) - paths_imported.set(interface.module_own_path); interfaces.enqueue(&interface); @@ -1583,7 +1581,6 @@ void generate_header(IDL::Interface const& interface) for (auto& path : interface.required_imported_paths) generate_include_for(generator, path); - emit_includes_for_all_imports(interface, generator, true); generator.set("name", interface.name); generator.set("fully_qualified_name", interface.fully_qualified_name); generator.set("wrapper_base_class", interface.wrapper_base_class); @@ -1747,7 +1744,7 @@ void generate_implementation(IDL::Interface const& interface) #include )~~~"); - emit_includes_for_all_imports(interface, generator, false); + emit_includes_for_all_imports(interface, generator); generator.append(R"~~~( // FIXME: This is a total hack until we can figure out the namespace for a given type somehow. @@ -2926,7 +2923,7 @@ void generate_prototype_implementation(IDL::Interface const& interface) for (auto& path : interface.required_imported_paths) generate_include_for(generator, path); - emit_includes_for_all_imports(interface, generator, false, interface.pair_iterator_types.has_value()); + emit_includes_for_all_imports(interface, generator, interface.pair_iterator_types.has_value()); generator.append(R"~~~( @@ -3374,7 +3371,7 @@ void generate_iterator_implementation(IDL::Interface const& interface) for (auto& path : interface.required_imported_paths) generate_include_for(generator, path); - emit_includes_for_all_imports(interface, generator, false, true); + emit_includes_for_all_imports(interface, generator, true); generator.append(R"~~~( @@ -3487,7 +3484,7 @@ void generate_iterator_prototype_implementation(IDL::Interface const& interface) #endif )~~~"); - emit_includes_for_all_imports(interface, generator, false, true); + emit_includes_for_all_imports(interface, generator, true); generator.append(R"~~~( // FIXME: This is a total hack until we can figure out the namespace for a given type somehow.