RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:27:45 +00:00
Code Issues Activity Actions

LibKeyboard: Mark CharacterMap::get_char as const

Browse source 
Also, mark character_map_name method as const and make it to return
const String& instead of const String.
This commit is contained in:
Liav A 2021-04-02 21:12:47 +03:00 • committed by Andreas Kling
parent 8a12d02b9a
commit 32dd9c554b
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibKeyboard/CharacterMap.cpp
View file

@ -74,7 +74,7 @@ Result<CharacterMap, OSError> CharacterMap::fetch_system_map()
#endif #endif
u32 CharacterMap::get_char(KeyEvent event) u32 CharacterMap::get_char(KeyEvent event) const
{ {
auto modifiers = event.modifiers(); auto modifiers = event.modifiers();
auto index = event.scancode & 0xFF; // Index is last byte of scan code. auto index = event.scancode & 0xFF; // Index is last byte of scan code.
@ -121,7 +121,7 @@ void CharacterMap::set_character_map_name(const String& character_map_name)
m_character_map_name = character_map_name; m_character_map_name = character_map_name;
} }
const String CharacterMap::character_map_name() const String& CharacterMap::character_map_name() const
{ {
return m_character_map_name; return m_character_map_name;
} }

4
Userland/Libraries/LibKeyboard/CharacterMap.h
View file

@ -47,12 +47,12 @@ public:
static Result<CharacterMap, OSError> fetch_system_map(); static Result<CharacterMap, OSError> fetch_system_map();
#endif #endif
u32 get_char(KeyEvent); u32 get_char(KeyEvent) const;
void set_character_map_data(CharacterMapData character_map_data); void set_character_map_data(CharacterMapData character_map_data);
void set_character_map_name(const String& character_map_name); void set_character_map_name(const String& character_map_name);
const CharacterMapData& character_map_data() const { return m_character_map_data; }; const CharacterMapData& character_map_data() const { return m_character_map_data; };
const String character_map_name(); const String& character_map_name() const;
private: private:
CharacterMapData m_character_map_data; CharacterMapData m_character_map_data;