RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:17:45 +00:00
Code Issues Activity Actions

LibWeb: Apply CSS text-transform during layout

Browse source 
Previously we were doing this at the painting stage, which meant that
layout potentially used the wrong glyphs when measuring text.

This would lead to incorrect layout metrics and was visible on the
HTML5Test score display, for example. :^)
This commit is contained in:
Andreas Kling 2022-12-23 19:57:52 +01:00
parent cf47c850e7
commit 32e35a02f9
2 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -513,13 +513,7 @@ static void paint_text_fragment(PaintContext& context, Layout::TextNode const& t
if (text_node.document().inspected_node() == &text_node.dom_node())
context.painter().draw_rect(fragment_absolute_device_rect.to_type<int>(), Color::Magenta);
// FIXME: text-transform should be done already in layout, since uppercase glyphs may be wider than lowercase, etc.
auto text = text_node.text_for_rendering();
auto text_transform = text_node.computed_values().text_transform();
if (text_transform == CSS::TextTransform::Uppercase)
text = Unicode::to_unicode_uppercase_full(text_node.text_for_rendering());
if (text_transform == CSS::TextTransform::Lowercase)
text = Unicode::to_unicode_lowercase_full(text_node.text_for_rendering());
DevicePixelPoint baseline_start { fragment_absolute_device_rect.x(), fragment_absolute_device_rect.y() + context.rounded_device_pixels(fragment.baseline()) };
Utf8View view { text.substring_view(fragment.start(), fragment.length()) };