RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:47:35 +00:00
Code Issues Activity Actions

LibWeb: Simplify LayoutBlock::layout_block_children() a little bit

Browse source 
No need to worry about inline children if children are not inline(!)
This commit is contained in:
Andreas Kling 2020-06-14 16:47:33 +02:00
parent 62615dfc31
commit 332c471301
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWeb/Layout/LayoutBlock.cpp
View file

@ -143,15 +143,10 @@ void LayoutBlock::layout_block_children(LayoutMode layout_mode)
{ {
ASSERT(!children_are_inline()); ASSERT(!children_are_inline());
float content_height = 0; float content_height = 0;
for_each_child([&](auto& child) { for_each_child_of_type<LayoutBlock>([&](auto& child) {
// FIXME: What should we do here? Something like a <table> might have a bunch of useless text children.. child.layout(layout_mode);
if (child.is_inline()) if (!child.is_absolutely_positioned())
return; content_height = max(content_height, child.effective_offset().y() + child.height() + child.box_model().margin_box(*this).bottom);
auto& child_block = static_cast<LayoutBlock&>(child);
child_block.layout(layout_mode);
if (!child_block.is_absolutely_positioned())
content_height = max(content_height, child_block.effective_offset().y() + child_block.height() + child_block.box_model().margin_box(*this).bottom);
}); });
if (layout_mode != LayoutMode::Default) { if (layout_mode != LayoutMode::Default) {
float max_width = 0; float max_width = 0;