RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:57:46 +00:00
Code Issues Activity Actions

LibWeb: Protect against null deref during Web::Page initialization

Browse source 
BrowsingContext::set_active_document() may end up asking for the Page's
top level browsing context before Page has one. Do a workaround for now
where we have an API to ask if it's initialized.

Long-term we should find a cleaner solution.
This commit is contained in:
Andreas Kling 2023-05-27 18:37:02 +02:00
parent f07ac8f20a
commit 33500bb6db
3 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Page/Page.h
View file

@ -44,6 +44,9 @@ public:
PageClient& client() { return m_client; }
PageClient const& client() const { return m_client; }
// FIXME: This is a hack.
bool top_level_browsing_context_is_initialized() const;
HTML::BrowsingContext& top_level_browsing_context();
HTML::BrowsingContext const& top_level_browsing_context() const;