RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:27:34 +00:00
Code Issues Activity Actions

Userland: Convert config listener callbacks to use StringView

Browse source 
The immutability of the string is not relevant here, since the string
we're given was allocated in the IPC serialization layer and will be
destroyed shortly afterwards. Additionally, noone relies on
DeprecatedString-specific functionality. This will make it easier to
convert the IPC layer itself to String later on.
This commit is contained in:
kleines Filmröllchen 2023-06-26 21:05:53 +02:00 • committed by Sam Atkins
parent 5f1dbbaaa6
commit 33829f05fe
22 changed files with 46 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/BrowserWindow.cpp
View file

@ -681,7 +681,7 @@ void BrowserWindow::proxy_mappings_changed()
});
}
void BrowserWindow::config_string_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, DeprecatedString const& value)
void BrowserWindow::config_string_did_change(StringView domain, StringView group, StringView key, StringView value)
{
if (domain != "Browser")
return;
@ -707,7 +707,7 @@ void BrowserWindow::config_string_did_change(DeprecatedString const& domain, Dep
// TODO: ColorScheme
}
void BrowserWindow::config_bool_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, bool value)
void BrowserWindow::config_bool_did_change(StringView domain, StringView group, StringView key, bool value)
{
dbgln("{} {} {} {}", domain, group, key, value);
if (domain != "Browser" || group != "Preferences")