RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 10:37:44 +00:00
Code Issues Activity Actions

Userland: Convert config listener callbacks to use StringView

Browse source 
The immutability of the string is not relevant here, since the string
we're given was allocated in the IPC serialization layer and will be
destroyed shortly afterwards. Additionally, noone relies on
DeprecatedString-specific functionality. This will make it easier to
convert the IPC layer itself to String later on.
This commit is contained in:
kleines Filmröllchen 2023-06-26 21:05:53 +02:00 • committed by Sam Atkins
parent 5f1dbbaaa6
commit 33829f05fe
22 changed files with 46 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCards/CardGame.cpp
View file

@ -112,7 +112,7 @@ void CardGame::dump_layout() const
dbgln("{}", stack);
}
void CardGame::config_string_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, DeprecatedString const& value)
void CardGame::config_string_did_change(StringView domain, StringView group, StringView key, StringView value)
{
if (domain == "Games" && group == "Cards") {
if (key == "BackgroundColor") {

2
Userland/Libraries/LibCards/CardGame.h
View file

@ -57,7 +57,7 @@ protected:
CardGame();
private:
virtual void config_string_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, DeprecatedString const& value) override;
virtual void config_string_did_change(StringView domain, StringView group, StringView key, StringView value) override;
Vector<NonnullRefPtr<CardStack>> m_stacks;

14
Userland/Libraries/LibConfig/Listener.cpp
View file

@ -29,31 +29,31 @@ void Listener::for_each(Function<void(Listener&)> callback)
callback(*listener);
}
void Listener::config_string_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, DeprecatedString const&)
void Listener::config_string_did_change(StringView, StringView, StringView, StringView)
{
}
void Listener::config_i32_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, i32)
void Listener::config_i32_did_change(StringView, StringView, StringView, i32)
{
}
void Listener::config_u32_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, u32)
void Listener::config_u32_did_change(StringView, StringView, StringView, u32)
{
}
void Listener::config_bool_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, bool)
void Listener::config_bool_did_change(StringView, StringView, StringView, bool)
{
}
void Listener::config_key_was_removed(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&)
void Listener::config_key_was_removed(StringView, StringView, StringView)
{
}
void Listener::config_group_was_removed(DeprecatedString const&, DeprecatedString const&)
void Listener::config_group_was_removed(StringView, StringView)
{
}
void Listener::config_group_was_added(DeprecatedString const&, DeprecatedString const&)
void Listener::config_group_was_added(StringView, StringView)
{
}

14
Userland/Libraries/LibConfig/Listener.h
View file

@ -16,13 +16,13 @@ public:
static void for_each(Function<void(Listener&)>);
virtual void config_string_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, DeprecatedString const& value);
virtual void config_i32_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, i32 value);
virtual void config_u32_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, u32 value);
virtual void config_bool_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, bool value);
virtual void config_key_was_removed(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key);
virtual void config_group_was_removed(DeprecatedString const& domain, DeprecatedString const& group);
virtual void config_group_was_added(DeprecatedString const& domain, DeprecatedString const& group);
virtual void config_string_did_change(StringView domain, StringView group, StringView key, StringView value);
virtual void config_i32_did_change(StringView domain, StringView group, StringView key, i32 value);
virtual void config_u32_did_change(StringView domain, StringView group, StringView key, u32 value);
virtual void config_bool_did_change(StringView domain, StringView group, StringView key, bool value);
virtual void config_key_was_removed(StringView domain, StringView group, StringView key);
virtual void config_group_was_removed(StringView domain, StringView group);
virtual void config_group_was_added(StringView domain, StringView group);
protected:
Listener();

4
Userland/Libraries/LibGUI/Calendar.cpp
View file

@ -769,7 +769,7 @@ size_t Calendar::day_of_week_index(DeprecatedString const& day_name)
return AK::find_index(day_names.begin(), day_names.end(), day_name);
}
void Calendar::config_string_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, DeprecatedString const& value)
void Calendar::config_string_did_change(StringView domain, StringView group, StringView key, StringView value)
{
if (domain == "Calendar" && group == "View" && key == "FirstDayOfWeek") {
m_first_day_of_week = static_cast<DayOfWeek>(day_of_week_index(value));
@ -780,7 +780,7 @@ void Calendar::config_string_did_change(DeprecatedString const& domain, Deprecat
}
}
void Calendar::config_i32_did_change(DeprecatedString const& domain, DeprecatedString const& group, DeprecatedString const& key, i32 value)
void Calendar::config_i32_did_change(StringView domain, StringView group, StringView key, i32 value)
{
if (domain == "Calendar" && group == "View" && key == "WeekendLength") {
m_weekend_length = value;

4
Userland/Libraries/LibGUI/Calendar.h
View file

@ -71,8 +71,8 @@ public:
m_unadjusted_tile_size.set_height(height);
}
virtual void config_string_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, DeprecatedString const&) override;
virtual void config_i32_did_change(DeprecatedString const&, DeprecatedString const&, DeprecatedString const&, i32 value) override;
virtual void config_string_did_change(StringView, StringView, StringView, StringView) override;
virtual void config_i32_did_change(StringView, StringView, StringView, i32 value) override;
Function<void()> on_tile_click;
Function<void()> on_tile_doubleclick;