RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:58:11 +00:00
Code Issues Activity Actions

AK: Try to use StringViews more for substrings and splitting.

Browse source
This commit is contained in:
Andreas Kling 2019-04-16 02:39:16 +02:00
parent a082738f04
commit 33920df299
9 changed files with 133 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

44
AK/String.cpp
View file

@ -47,18 +47,24 @@ String String::isolated_copy() const
return String(move(*impl));
}
String String::substring(ssize_t start, ssize_t length) const
String String::substring(int start, int length) const
{
if (!length)
return empty();
return { };
ASSERT(m_impl);
ASSERT(start + length <= m_impl->length());
// FIXME: This needs some input bounds checking.
char* buffer;
auto new_impl = StringImpl::create_uninitialized(length, buffer);
memcpy(buffer, characters() + start, length);
buffer[length] = '\0';
return new_impl;
return { characters() + start, length };
}
StringView String::substring_view(int start, int length) const
{
if (!length)
return { };
ASSERT(m_impl);
ASSERT(start + length <= m_impl->length());
// FIXME: This needs some input bounds checking.
return { characters() + start, length };
}
Vector<String> String::split(const char separator) const
@ -85,6 +91,30 @@ Vector<String> String::split(const char separator) const
return v;
}
Vector<StringView> String::split_view(const char separator) const
{
if (is_empty())
return { };
Vector<StringView> v;
ssize_t substart = 0;
for (ssize_t i = 0; i < length(); ++i) {
char ch = characters()[i];
if (ch == separator) {
ssize_t sublen = i - substart;
if (sublen != 0)
v.append(substring_view(substart, sublen));
substart = i + 1;
}
}
ssize_t taillen = length() - substart;
if (taillen != 0)
v.append(substring_view(substart, taillen));
if (characters()[length() - 1] == separator)
v.append(empty().view());
return v;
}
ByteBuffer String::to_byte_buffer() const
{
if (!m_impl)