RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 17:48:12 +00:00
Code Issues Activity Actions

Kernel: Store coredump metadata properties as KStrings

Browse source 
This patch also replaces the HashMap previously used to store coredump
properties with a plain AK::Array.
This commit is contained in:
Andreas Kling 2021-08-05 23:43:10 +02:00
parent 95669fa861
commit 33adc3a42d
6 changed files with 55 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Kernel/Process.cpp
View file

@ -875,9 +875,26 @@ void Process::set_dumpable(bool dumpable)
m_dumpable = dumpable;
}
void Process::set_coredump_metadata(const String& key, String value)
KResult Process::set_coredump_property(NonnullOwnPtr<KString> key, NonnullOwnPtr<KString> value)
{
m_coredump_metadata.set(key, move(value));
// Write it into the first available property slot.
for (auto& slot : m_coredump_properties) {
if (slot.key)
continue;
slot.key = move(key);
slot.value = move(value);
return KSuccess;
}
return ENOBUFS;
}
KResult Process::try_set_coredump_property(StringView key, StringView value)
{
auto key_kstring = KString::try_create(key);
auto value_kstring = KString::try_create(value);
if (key_kstring && value_kstring)
return set_coredump_property(key_kstring.release_nonnull(), value_kstring.release_nonnull());
return ENOMEM;
};
}