RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:27:34 +00:00
Code Issues Activity Actions

Userland: Fix remaining smart pointer const-correctness issues

Browse source
This commit is contained in:
Andreas Kling 2023-02-20 19:03:59 +01:00
parent faa1a09042
commit 33e87d1627
17 changed files with 23 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/FontEditor/UndoSelection.h
View file

@ -13,7 +13,7 @@
class UndoSelection : public RefCounted<UndoSelection> {
public:
explicit UndoSelection(int const start, int const size, u32 const active_glyph, Gfx::BitmapFont const& font, NonnullRefPtr<GUI::GlyphMapWidget> glyph_map_widget)
explicit UndoSelection(int const start, int const size, u32 const active_glyph, Gfx::BitmapFont& font, NonnullRefPtr<GUI::GlyphMapWidget> glyph_map_widget)
: m_start(start)
, m_size(size)
, m_active_glyph(active_glyph)

2
Userland/Applications/Help/ManualModel.cpp
View file

@ -149,7 +149,7 @@ GUI::ModelIndex ManualModel::parent_index(const GUI::ModelIndex& index) const
return {};
auto children = maybe_children.release_value();
for (size_t row = 0; row < children.size(); row++) {
Manual::Node* child_at_row = children[row];
Manual::Node const* child_at_row = children[row];
if (child_at_row == parent)
return create_index(row, 0, parent);
}

2
Userland/Applications/ImageViewer/ViewWidget.h
View file

@ -66,7 +66,7 @@ private:
Vector<DeprecatedString> load_files_from_directory(DeprecatedString const& path) const;
DeprecatedString m_path;
RefPtr<Gfx::Bitmap> m_bitmap;
RefPtr<Gfx::Bitmap const> m_bitmap;
Optional<ImageDecoderClient::DecodedImage> m_decoded_image;
size_t m_current_frame_index { 0 };

2
Userland/Applications/PixelPaint/Tools/TextTool.h
View file

@ -53,7 +53,7 @@ private:
RefPtr<Core::Timer> m_cursor_blink_timer;
RefPtr<PixelPaint::TextToolEditor> m_text_editor;
Gfx::IntPoint m_add_text_position { 0, 0 };
RefPtr<Gfx::Font> m_selected_font;
RefPtr<Gfx::Font const> m_selected_font;
bool m_text_input_is_active { false };
bool m_cursor_blink_state { false };
bool m_mouse_is_over_text { false };

4
Userland/Applications/TerminalSettings/TerminalSettingsWidget.h
View file

@ -47,13 +47,13 @@ private:
TerminalSettingsViewWidget();
void write_back_settings() const;
RefPtr<Gfx::Font> m_font;
RefPtr<Gfx::Font const> m_font;
float m_opacity;
DeprecatedString m_color_scheme;
VT::CursorShape m_cursor_shape { VT::CursorShape::Block };
bool m_cursor_is_blinking_set { true };
RefPtr<Gfx::Font> m_original_font;
RefPtr<Gfx::Font const> m_original_font;
float m_original_opacity;
DeprecatedString m_original_color_scheme;
VT::CursorShape m_original_cursor_shape;

2
Userland/Applications/ThemeEditor/PreviewWidget.cpp
View file

@ -39,7 +39,7 @@ public:
return gallery;
}
void set_preview_palette(Gfx::Palette const& palette)
void set_preview_palette(Gfx::Palette& palette)
{
set_palette(palette);
Function<void(GUI::Widget&)> recurse = [&](GUI::Widget& parent_widget) {

3
Userland/Applications/VideoPlayer/VideoFrameWidget.h
View file

@ -26,7 +26,6 @@ public:
virtual ~VideoFrameWidget() override = default;
void set_bitmap(Gfx::Bitmap const*);
Gfx::Bitmap* bitmap() { return m_bitmap.ptr(); }
Gfx::Bitmap const* bitmap() const { return m_bitmap.ptr(); }
void set_sizing_mode(VideoSizingMode value) { m_sizing_mode = value; }
@ -44,7 +43,7 @@ protected:
virtual void paint_event(GUI::PaintEvent&) override;
private:
RefPtr<Gfx::Bitmap> m_bitmap;
RefPtr<Gfx::Bitmap const> m_bitmap;
VideoSizingMode m_sizing_mode { VideoSizingMode::Fit };
bool m_auto_resize { false };
};