RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:07:45 +00:00
Code Issues Activity Actions

LibJS: Don't hoist functions under certain circumstances

Browse source 
When a lexical declaration with the same name as a function exists,
the function is not hoisted (annex B).
This commit is contained in:
Hendi 2021-07-05 21:45:34 +02:00 • committed by Linus Groh
parent c194afd17c
commit 3411d50737
4 changed files with 45 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Parser.h
View file

@ -201,12 +201,18 @@ private:
Function,
Block,
};
struct HoistableDeclaration {
NonnullRefPtr<FunctionDeclaration> declaration;
NonnullRefPtr<Scope> scope; // where it is actually declared
};
Type type;
RefPtr<Scope> parent;
NonnullRefPtrVector<FunctionDeclaration> function_declarations;
NonnullRefPtrVector<FunctionDeclaration> hoisted_function_declarations;
Vector<HoistableDeclaration> hoisted_function_declarations;
HashTable<FlyString> lexical_declarations;
explicit Scope(Type, RefPtr<Scope>);
RefPtr<Scope> get_current_function_scope();