RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:08:11 +00:00
Code Issues Activity Actions

Browser: Avoid unnecessary copies of temporary Storages

Browse source
This commit is contained in:
Ben Wiederhake 2023-06-07 11:36:56 +02:00 • committed by Andreas Kling
parent a8b9130ceb
commit 342e1c6eab
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/StorageWidget.cpp
View file

@ -109,7 +109,7 @@ void StorageWidget::clear_cookies()
void StorageWidget::set_local_storage_entries(OrderedHashMap<DeprecatedString, DeprecatedString> entries) void StorageWidget::set_local_storage_entries(OrderedHashMap<DeprecatedString, DeprecatedString> entries)
{ {
m_local_storage_model->set_items(entries); m_local_storage_model->set_items(move(entries));
} }
void StorageWidget::clear_local_storage_entries() void StorageWidget::clear_local_storage_entries()
@ -119,7 +119,7 @@ void StorageWidget::clear_local_storage_entries()
void StorageWidget::set_session_storage_entries(OrderedHashMap<DeprecatedString, DeprecatedString> entries) void StorageWidget::set_session_storage_entries(OrderedHashMap<DeprecatedString, DeprecatedString> entries)
{ {
m_session_storage_model->set_items(entries); m_session_storage_model->set_items(move(entries));
} }
void StorageWidget::clear_session_storage_entries() void StorageWidget::clear_session_storage_entries()

4
Userland/Applications/Browser/Tab.cpp
View file

@ -865,13 +865,13 @@ void Tab::show_storage_inspector()
if (on_get_local_storage_entries) { if (on_get_local_storage_entries) {
auto local_storage_entries = on_get_local_storage_entries(); auto local_storage_entries = on_get_local_storage_entries();
m_storage_widget->clear_local_storage_entries(); m_storage_widget->clear_local_storage_entries();
m_storage_widget->set_local_storage_entries(local_storage_entries); m_storage_widget->set_local_storage_entries(move(local_storage_entries));
} }
if (on_get_session_storage_entries) { if (on_get_session_storage_entries) {
auto session_storage_entries = on_get_session_storage_entries(); auto session_storage_entries = on_get_session_storage_entries();
m_storage_widget->clear_session_storage_entries(); m_storage_widget->clear_session_storage_entries();
m_storage_widget->set_session_storage_entries(session_storage_entries); m_storage_widget->set_session_storage_entries(move(session_storage_entries));
} }
auto* window = m_storage_widget->window(); auto* window = m_storage_widget->window();