RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:58:11 +00:00
Code Issues Activity Actions

Kernel: Properly implement SO_ERROR option

Browse source 
This fixes the placeholder stub for the SO_ERROR via getsockopt. It
leverages the m_so_error value that each socket maintains. The SO_ERROR
option obtains and then clears this field, which is useful when checking
for errors that occur between socket calls. This uses an integer value
to return the SO_ERROR status.

Resolves #146
This commit is contained in:
brapru 2021-08-01 16:36:28 -04:00 • committed by Andreas Kling
parent 0095c7cb7d
commit 342e1f0a84
2 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Net/LocalSocket.cpp
View file

@ -343,9 +343,8 @@ KResultOr<size_t> LocalSocket::recvfrom(FileDescription& description, UserOrKern
}
} else if (!can_read(description, 0)) {
auto unblock_flags = Thread::FileDescriptionBlocker::BlockFlags::None;
if (Thread::current()->block<Thread::ReadBlocker>({}, description, unblock_flags).was_interrupted()) {
if (Thread::current()->block<Thread::ReadBlocker>({}, description, unblock_flags).was_interrupted())
return set_so_error(EINTR);
}
}
if (!has_attached_peer(description) && socket_buffer->is_empty())
return 0;