RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 11:47:34 +00:00
Code Issues Activity Actions

AK: Make "foo"_string infallible

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405.
This commit is contained in:
Andreas Kling 2023-08-07 11:12:38 +02:00
parent db2a8725c6
commit 34344120f2
181 changed files with 626 additions and 630 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/GMLPlayground/main.cpp
View file

@ -24,7 +24,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto app = TRY(GUI::Application::create(arguments));
Config::pledge_domains({ "GMLPlayground", "Calendar" });
app->set_config_domain(TRY("GMLPlayground"_string));
app->set_config_domain("GMLPlayground"_string);
TRY(Core::System::unveil("/res", "r"));
TRY(Core::System::unveil("/tmp/session/%sid/portal/launch", "rw"));

4
Userland/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp
View file

@ -148,7 +148,7 @@ RefPtr<GUI::Menu> DebugInfoWidget::get_context_menu_for_variable(const GUI::Mode
NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_variables_tab()
{
auto variables_widget = GUI::Widget::construct();
variables_widget->set_title("Variables"_string.release_value_but_fixme_should_propagate_errors());
variables_widget->set_title("Variables"_string);
variables_widget->set_layout<GUI::HorizontalBoxLayout>();
m_variables_view = variables_widget->add<GUI::TreeView>();
@ -165,7 +165,7 @@ NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_variables_tab()
NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_registers_tab()
{
auto registers_widget = GUI::Widget::construct();
registers_widget->set_title("Registers"_string.release_value_but_fixme_should_propagate_errors());
registers_widget->set_title("Registers"_string);
registers_widget->set_layout<GUI::HorizontalBoxLayout>();
m_registers_view = registers_widget->add<GUI::TableView>();

4
Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp
View file

@ -79,9 +79,9 @@ ErrorOr<String> DisassemblyModel::column_name(int column) const
case Column::Address:
return "Address"_short_string;
case Column::InstructionBytes:
return TRY("Insn Bytes"_string);
return "Insn Bytes"_string;
case Column::Disassembly:
return TRY("Disassembly"_string);
return "Disassembly"_string;
default:
VERIFY_NOT_REACHED();
}

2
Userland/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp
View file

@ -51,7 +51,7 @@ void DisassemblyWidget::update_state(Debug::DebugSession const& debug_session, P
if (containing_function.has_value())
m_function_name_label->set_text(String::from_deprecated_string(containing_function.value().name).release_value_but_fixme_should_propagate_errors());
else
m_function_name_label->set_text("<missing>"_string.release_value_but_fixme_should_propagate_errors());
m_function_name_label->set_text("<missing>"_string);
show_disassembly();
} else {
hide_disassembly("No disassembly to show for this function");

2
Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp
View file

@ -90,7 +90,7 @@ ErrorOr<String> RegistersModel::column_name(int column) const
{
switch (column) {
case Column::Register:
return TRY("Register"_string);
return "Register"_string;
case Column::Value:
return "Value"_short_string;
default:

4
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp
View file

@ -115,7 +115,7 @@ void NewProjectDialog::update_dialog()
if (project_template) {
m_description_label->set_text(String::from_deprecated_string(project_template->description()).release_value_but_fixme_should_propagate_errors());
} else {
m_description_label->set_text("Select a project template to continue."_string.release_value_but_fixme_should_propagate_errors());
m_description_label->set_text("Select a project template to continue."_string);
m_input_valid = false;
}
@ -124,7 +124,7 @@ void NewProjectDialog::update_dialog()
if (maybe_project_path.has_value()) {
m_full_path_label->set_text(String::from_deprecated_string(maybe_project_path.value()).release_value_but_fixme_should_propagate_errors());
} else {
m_full_path_label->set_text("Invalid name or creation directory."_string.release_value_but_fixme_should_propagate_errors());
m_full_path_label->set_text("Invalid name or creation directory."_string);
m_input_valid = false;
}

4
Userland/DevTools/HackStudio/FindInFilesWidget.cpp
View file

@ -43,7 +43,7 @@ public:
{
switch (column) {
case Column::Filename:
return TRY("Filename"_string);
return "Filename"_string;
case Column::Location:
return "#"_short_string;
case Column::MatchedText:
@ -122,7 +122,7 @@ FindInFilesWidget::FindInFilesWidget()
m_textbox = top_container.add<GUI::TextBox>();
m_button = top_container.add<GUI::Button>("Find"_string.release_value_but_fixme_should_propagate_errors());
m_button = top_container.add<GUI::Button>("Find"_string);
m_button->set_fixed_width(50);
m_result_view = add<GUI::TableView>();

4
Userland/DevTools/HackStudio/GMLPreviewWidget.cpp
View file

@ -22,7 +22,7 @@ void GMLPreviewWidget::load_gml(DeprecatedString const& gml)
if (gml.is_empty()) {
auto& label = add<GUI::Label>();
label.set_text("Open a .gml file to show the preview"_string.release_value_but_fixme_should_propagate_errors());
label.set_text("Open a .gml file to show the preview"_string);
return;
}
@ -34,7 +34,7 @@ void GMLPreviewWidget::load_gml(DeprecatedString const& gml)
if (children().is_empty()) {
auto& label = add<GUI::Label>();
label.set_text("Failed to load GML!"_string.release_value_but_fixme_should_propagate_errors());
label.set_text("Failed to load GML!"_string);
}
}

2
Userland/DevTools/HackStudio/Git/GitWidget.cpp
View file

@ -36,7 +36,7 @@ GitWidget::GitWidget()
refresh_button.on_click = [this](int) { refresh(); };
auto& unstaged_label = unstaged_header.add<GUI::Label>();
unstaged_label.set_text("Unstaged"_string.release_value_but_fixme_should_propagate_errors());
unstaged_label.set_text("Unstaged"_string);
unstaged_header.set_fixed_height(20);
m_unstaged_files = unstaged.add<GitFilesView>(

16
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -492,7 +492,7 @@ ErrorOr<NonnullRefPtr<GUI::Menu>> HackStudioWidget::create_project_tree_view_con
m_tree_view_rename_action = GUI::CommonActions::make_rename_action([this](GUI::Action const&) {
m_project_tree_view->begin_editing(m_project_tree_view->cursor_index());
});
auto project_tree_view_context_menu = GUI::Menu::construct(TRY("Project Files"_string));
auto project_tree_view_context_menu = GUI::Menu::construct("Project Files"_string);
auto& new_file_submenu = project_tree_view_context_menu->add_submenu("N&ew..."_short_string);
for (auto& new_file_action : m_new_file_actions) {
@ -777,7 +777,7 @@ void HackStudioWidget::add_new_editor_tab_widget(GUI::Widget& parent)
void HackStudioWidget::add_new_editor(GUI::TabWidget& parent)
{
auto& wrapper = parent.add_tab<EditorWrapper>("(Untitled)"_string.release_value_but_fixme_should_propagate_errors());
auto& wrapper = parent.add_tab<EditorWrapper>("(Untitled)"_string);
parent.set_active_widget(&wrapper);
if (parent.children().size() > 1 || m_all_editor_tab_widgets.size() > 1)
parent.set_close_button_enabled(true);
@ -985,7 +985,7 @@ ErrorOr<NonnullRefPtr<GUI::Action>> HackStudioWidget::create_add_terminal_action
return GUI::Action::create("Add New &Terminal", { Mod_Ctrl | Mod_Alt, Key_T },
icon,
[this](auto&) {
auto& terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Terminal"_string.release_value_but_fixme_should_propagate_errors());
auto& terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Terminal"_string);
terminal_wrapper.on_command_exit = [&]() {
deferred_invoke([this]() {
m_action_tab_widget->remove_tab(*m_action_tab_widget->active_widget());
@ -1342,7 +1342,7 @@ ErrorOr<void> HackStudioWidget::create_action_tab(GUI::Widget& parent)
first_time = false;
};
m_find_in_files_widget = m_action_tab_widget->add_tab<FindInFilesWidget>(TRY("Find"_string));
m_find_in_files_widget = m_action_tab_widget->add_tab<FindInFilesWidget>("Find"_string);
m_todo_entries_widget = m_action_tab_widget->add_tab<ToDoEntriesWidget>("TODO"_short_string);
m_terminal_wrapper = m_action_tab_widget->add_tab<TerminalWrapper>("Console"_short_string, false);
auto debug_info_widget = TRY(DebugInfoWidget::create());
@ -1353,13 +1353,13 @@ ErrorOr<void> HackStudioWidget::create_action_tab(GUI::Widget& parent)
open_file(get_absolute_path(source_position.file_path), source_position.line_number - 1);
};
m_disassembly_widget = m_action_tab_widget->add_tab<DisassemblyWidget>(TRY("Disassembly"_string));
m_disassembly_widget = m_action_tab_widget->add_tab<DisassemblyWidget>("Disassembly"_string);
m_git_widget = m_action_tab_widget->add_tab<GitWidget>("Git"_short_string);
m_git_widget->set_view_diff_callback([this](auto const& original_content, auto const& diff) {
m_diff_viewer->set_content(original_content, diff);
set_edit_mode(EditMode::Diff);
});
m_gml_preview_widget = m_action_tab_widget->add_tab<GMLPreviewWidget>(TRY("GML Preview"_string), "");
m_gml_preview_widget = m_action_tab_widget->add_tab<GMLPreviewWidget>("GML Preview"_string, "");
ToDoEntries::the().on_update = [this]() {
m_todo_entries_widget->refresh();
@ -1432,7 +1432,7 @@ ErrorOr<void> HackStudioWidget::create_file_menu(GUI::Window& window)
new_submenu.add_action(*m_new_directory_action);
file_menu.add_action(*m_open_action);
m_recent_projects_submenu = &file_menu.add_submenu(TRY("Open &Recent"_string));
m_recent_projects_submenu = &file_menu.add_submenu("Open &Recent"_string);
{
auto icon = TRY(Gfx::Bitmap::load_from_file("/res/icons/16x16/open-recent.png"sv));
m_recent_projects_submenu->set_icon(icon);
@ -1511,7 +1511,7 @@ ErrorOr<void> HackStudioWidget::create_view_menu(GUI::Window& window)
view_menu.add_separator();
m_wrapping_mode_actions.set_exclusive(true);
auto& wrapping_mode_menu = view_menu.add_submenu(TRY("&Wrapping Mode"_string));
auto& wrapping_mode_menu = view_menu.add_submenu("&Wrapping Mode"_string);
m_no_wrapping_action = GUI::Action::create_checkable("&No Wrapping", [&](auto&) {
m_wrapping_mode = GUI::TextEditor::WrappingMode::NoWrap;
for (auto& wrapper : m_all_editor_wrappers)

2
Userland/DevTools/HackStudio/ToDoEntriesWidget.cpp
View file

@ -34,7 +34,7 @@ public:
{
switch (column) {
case Column::Filename:
return TRY("Filename"_string);
return "Filename"_string;
case Column::Text:
return "Text"_short_string;
case Column::Line:

8
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -135,15 +135,15 @@ ErrorOr<String> DisassemblyModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::Address:
return "Address"_short_string;
case Column::InstructionBytes:
return TRY("Insn Bytes"_string);
return "Insn Bytes"_string;
case Column::Disassembly:
return TRY("Disassembly"_string);
return "Disassembly"_string;
case Column::SourceLocation:
return TRY("Source Location"_string);
return "Source Location"_string;
default:
VERIFY_NOT_REACHED();
}

4
Userland/DevTools/Profiler/FilesystemEventModel.cpp
View file

@ -148,9 +148,9 @@ ErrorOr<String> FileEventModel::column_name(int column) const
case Column::Path:
return "Path"_short_string;
case Column::Count:
return TRY("Event Count"_string);
return "Event Count"_string;
case Column::Duration:
return TRY("Duration [ms]"_string);
return "Duration [ms]"_string;
default:
VERIFY_NOT_REACHED();
}

6
Userland/DevTools/Profiler/ProfileModel.cpp
View file

@ -78,15 +78,15 @@ ErrorOr<String> ProfileModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::SelfCount:
return m_profile.show_percentages() ? "% Self"_short_string : "# Self"_short_string;
case Column::ObjectName:
return "Object"_short_string;
case Column::StackFrame:
return TRY("Stack Frame"_string);
return "Stack Frame"_string;
case Column::SymbolAddress:
return TRY("Symbol Address"_string);
return "Symbol Address"_string;
default:
VERIFY_NOT_REACHED();
}

8
Userland/DevTools/Profiler/SamplesModel.cpp
View file

@ -34,17 +34,17 @@ ErrorOr<String> SamplesModel::column_name(int column) const
case Column::SampleIndex:
return "#"_short_string;
case Column::Timestamp:
return TRY("Timestamp"_string);
return "Timestamp"_string;
case Column::ProcessID:
return "PID"_short_string;
case Column::ThreadID:
return "TID"_short_string;
case Column::ExecutableName:
return TRY("Executable"_string);
return "Executable"_string;
case Column::LostSamples:
return TRY("Lost Samples"_string);
return "Lost Samples"_string;
case Column::InnermostStackFrame:
return TRY("Innermost Frame"_string);
return "Innermost Frame"_string;
case Column::Path:
return "Path"_short_string;
default:

6
Userland/DevTools/Profiler/SignpostsModel.cpp
View file

@ -32,17 +32,17 @@ ErrorOr<String> SignpostsModel::column_name(int column) const
case Column::SignpostIndex:
return "#"_short_string;
case Column::Timestamp:
return TRY("Timestamp"_string);
return "Timestamp"_string;
case Column::ProcessID:
return "PID"_short_string;
case Column::ThreadID:
return "TID"_short_string;
case Column::ExecutableName:
return TRY("Executable"_string);
return "Executable"_string;
case Column::SignpostString:
return "String"_short_string;
case Column::SignpostArgument:
return TRY("Argument"_string);
return "Argument"_string;
default:
VERIFY_NOT_REACHED();
}

6
Userland/DevTools/Profiler/SourceModel.cpp
View file

@ -126,11 +126,11 @@ ErrorOr<String> SourceModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::SourceCode:
return TRY("Source Code"_string);
return "Source Code"_string;
case Column::Location:
return TRY("Location"_string);
return "Location"_string;
case Column::LineNumber:
return "Line"_short_string;
default:

10
Userland/DevTools/Profiler/main.cpp
View file

@ -131,7 +131,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto tab_widget = TRY(main_splitter->try_add<GUI::TabWidget>());
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Call Tree"_string)));
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Call Tree"_string));
TRY(tree_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto bottom_splitter = TRY(tree_tab->try_add<GUI::VerticalSplitter>());
@ -180,7 +180,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
update_source_model();
});
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Samples"_string)));
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Samples"_string));
TRY(samples_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto samples_splitter = TRY(samples_tab->try_add<GUI::HorizontalSplitter>());
@ -194,7 +194,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
individual_sample_view->set_model(move(model));
};
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Signposts"_string)));
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Signposts"_string));
TRY(signposts_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto signposts_splitter = TRY(signposts_tab->try_add<GUI::HorizontalSplitter>());
@ -208,7 +208,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
individual_signpost_view->set_model(move(model));
};
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Flame Graph"_string)));
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Flame Graph"_string));
TRY(flamegraph_tab->try_set_layout<GUI::VerticalBoxLayout>(GUI::Margins { 4, 4, 4, 4 }));
auto flamegraph_view = TRY(flamegraph_tab->try_add<FlameGraphView>(profile->model(), ProfileModel::Column::StackFrame, ProfileModel::Column::SampleCount));
@ -256,7 +256,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
timeline_view->on_selection_change = [&] { statusbar_update(); };
flamegraph_view->on_hover_change = [&] { statusbar_update(); };
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Filesystem events"_string)));
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Filesystem events"_string));
TRY(filesystem_events_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto filesystem_events_tree_view = TRY(filesystem_events_tab->try_add<GUI::TreeView>());

4
Userland/DevTools/SQLStudio/MainWidget.cpp
View file

@ -164,7 +164,7 @@ ErrorOr<void> MainWidget::setup()
return;
m_run_script_action->set_enabled(false);
m_statusbar->set_text(1, "Disconnected"_string.release_value_but_fixme_should_propagate_errors());
m_statusbar->set_text(1, "Disconnected"_string);
if (m_connection_id.has_value()) {
m_sql_client->disconnect(*m_connection_id);
@ -245,7 +245,7 @@ ErrorOr<void> MainWidget::setup()
m_statusbar = find_descendant_of_type_named<GUI::Statusbar>("statusbar"sv);
m_statusbar->segment(1).set_mode(GUI::Statusbar::Segment::Mode::Auto);
m_statusbar->set_text(1, TRY("Disconnected"_string));
m_statusbar->set_text(1, "Disconnected"_string);
m_statusbar->segment(2).set_mode(GUI::Statusbar::Segment::Mode::Fixed);
m_statusbar->segment(2).set_fixed_width(font().width("Ln 0,000 Col 000"sv) + font().max_glyph_width());