RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:57:35 +00:00
Code Issues Activity Actions

AK: Make "foo"_string infallible

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405.
This commit is contained in:
Andreas Kling 2023-08-07 11:12:38 +02:00
parent db2a8725c6
commit 34344120f2
181 changed files with 626 additions and 630 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/DevTools/HackStudio/Debugger/DebugInfoWidget.cpp
View file

@ -148,7 +148,7 @@ RefPtr<GUI::Menu> DebugInfoWidget::get_context_menu_for_variable(const GUI::Mode
NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_variables_tab()
{
auto variables_widget = GUI::Widget::construct();
variables_widget->set_title("Variables"_string.release_value_but_fixme_should_propagate_errors());
variables_widget->set_title("Variables"_string);
variables_widget->set_layout<GUI::HorizontalBoxLayout>();
m_variables_view = variables_widget->add<GUI::TreeView>();
@ -165,7 +165,7 @@ NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_variables_tab()
NonnullRefPtr<GUI::Widget> DebugInfoWidget::build_registers_tab()
{
auto registers_widget = GUI::Widget::construct();
registers_widget->set_title("Registers"_string.release_value_but_fixme_should_propagate_errors());
registers_widget->set_title("Registers"_string);
registers_widget->set_layout<GUI::HorizontalBoxLayout>();
m_registers_view = registers_widget->add<GUI::TableView>();

4
Userland/DevTools/HackStudio/Debugger/DisassemblyModel.cpp
View file

@ -79,9 +79,9 @@ ErrorOr<String> DisassemblyModel::column_name(int column) const
case Column::Address:
return "Address"_short_string;
case Column::InstructionBytes:
return TRY("Insn Bytes"_string);
return "Insn Bytes"_string;
case Column::Disassembly:
return TRY("Disassembly"_string);
return "Disassembly"_string;
default:
VERIFY_NOT_REACHED();
}

2
Userland/DevTools/HackStudio/Debugger/DisassemblyWidget.cpp
View file

@ -51,7 +51,7 @@ void DisassemblyWidget::update_state(Debug::DebugSession const& debug_session, P
if (containing_function.has_value())
m_function_name_label->set_text(String::from_deprecated_string(containing_function.value().name).release_value_but_fixme_should_propagate_errors());
else
m_function_name_label->set_text("<missing>"_string.release_value_but_fixme_should_propagate_errors());
m_function_name_label->set_text("<missing>"_string);
show_disassembly();
} else {
hide_disassembly("No disassembly to show for this function");

2
Userland/DevTools/HackStudio/Debugger/RegistersModel.cpp
View file

@ -90,7 +90,7 @@ ErrorOr<String> RegistersModel::column_name(int column) const
{
switch (column) {
case Column::Register:
return TRY("Register"_string);
return "Register"_string;
case Column::Value:
return "Value"_short_string;
default: