RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:47:34 +00:00
Code Issues Activity Actions

AK: Make "foo"_string infallible

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405.
This commit is contained in:
Andreas Kling 2023-08-07 11:12:38 +02:00
parent db2a8725c6
commit 34344120f2
181 changed files with 626 additions and 630 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/Profiler/DisassemblyModel.cpp
View file

@ -135,15 +135,15 @@ ErrorOr<String> DisassemblyModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::Address:
return "Address"_short_string;
case Column::InstructionBytes:
return TRY("Insn Bytes"_string);
return "Insn Bytes"_string;
case Column::Disassembly:
return TRY("Disassembly"_string);
return "Disassembly"_string;
case Column::SourceLocation:
return TRY("Source Location"_string);
return "Source Location"_string;
default:
VERIFY_NOT_REACHED();
}

4
Userland/DevTools/Profiler/FilesystemEventModel.cpp
View file

@ -148,9 +148,9 @@ ErrorOr<String> FileEventModel::column_name(int column) const
case Column::Path:
return "Path"_short_string;
case Column::Count:
return TRY("Event Count"_string);
return "Event Count"_string;
case Column::Duration:
return TRY("Duration [ms]"_string);
return "Duration [ms]"_string;
default:
VERIFY_NOT_REACHED();
}

6
Userland/DevTools/Profiler/ProfileModel.cpp
View file

@ -78,15 +78,15 @@ ErrorOr<String> ProfileModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::SelfCount:
return m_profile.show_percentages() ? "% Self"_short_string : "# Self"_short_string;
case Column::ObjectName:
return "Object"_short_string;
case Column::StackFrame:
return TRY("Stack Frame"_string);
return "Stack Frame"_string;
case Column::SymbolAddress:
return TRY("Symbol Address"_string);
return "Symbol Address"_string;
default:
VERIFY_NOT_REACHED();
}

8
Userland/DevTools/Profiler/SamplesModel.cpp
View file

@ -34,17 +34,17 @@ ErrorOr<String> SamplesModel::column_name(int column) const
case Column::SampleIndex:
return "#"_short_string;
case Column::Timestamp:
return TRY("Timestamp"_string);
return "Timestamp"_string;
case Column::ProcessID:
return "PID"_short_string;
case Column::ThreadID:
return "TID"_short_string;
case Column::ExecutableName:
return TRY("Executable"_string);
return "Executable"_string;
case Column::LostSamples:
return TRY("Lost Samples"_string);
return "Lost Samples"_string;
case Column::InnermostStackFrame:
return TRY("Innermost Frame"_string);
return "Innermost Frame"_string;
case Column::Path:
return "Path"_short_string;
default:

6
Userland/DevTools/Profiler/SignpostsModel.cpp
View file

@ -32,17 +32,17 @@ ErrorOr<String> SignpostsModel::column_name(int column) const
case Column::SignpostIndex:
return "#"_short_string;
case Column::Timestamp:
return TRY("Timestamp"_string);
return "Timestamp"_string;
case Column::ProcessID:
return "PID"_short_string;
case Column::ThreadID:
return "TID"_short_string;
case Column::ExecutableName:
return TRY("Executable"_string);
return "Executable"_string;
case Column::SignpostString:
return "String"_short_string;
case Column::SignpostArgument:
return TRY("Argument"_string);
return "Argument"_string;
default:
VERIFY_NOT_REACHED();
}

6
Userland/DevTools/Profiler/SourceModel.cpp
View file

@ -126,11 +126,11 @@ ErrorOr<String> SourceModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
return m_profile.show_percentages() ? "% Samples"_string : "# Samples"_string;
case Column::SourceCode:
return TRY("Source Code"_string);
return "Source Code"_string;
case Column::Location:
return TRY("Location"_string);
return "Location"_string;
case Column::LineNumber:
return "Line"_short_string;
default:

10
Userland/DevTools/Profiler/main.cpp
View file

@ -131,7 +131,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto tab_widget = TRY(main_splitter->try_add<GUI::TabWidget>());
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Call Tree"_string)));
auto tree_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Call Tree"_string));
TRY(tree_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto bottom_splitter = TRY(tree_tab->try_add<GUI::VerticalSplitter>());
@ -180,7 +180,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
update_source_model();
});
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Samples"_string)));
auto samples_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Samples"_string));
TRY(samples_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto samples_splitter = TRY(samples_tab->try_add<GUI::HorizontalSplitter>());
@ -194,7 +194,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
individual_sample_view->set_model(move(model));
};
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Signposts"_string)));
auto signposts_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Signposts"_string));
TRY(signposts_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto signposts_splitter = TRY(signposts_tab->try_add<GUI::HorizontalSplitter>());
@ -208,7 +208,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
individual_signpost_view->set_model(move(model));
};
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Flame Graph"_string)));
auto flamegraph_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Flame Graph"_string));
TRY(flamegraph_tab->try_set_layout<GUI::VerticalBoxLayout>(GUI::Margins { 4, 4, 4, 4 }));
auto flamegraph_view = TRY(flamegraph_tab->try_add<FlameGraphView>(profile->model(), ProfileModel::Column::StackFrame, ProfileModel::Column::SampleCount));
@ -256,7 +256,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
timeline_view->on_selection_change = [&] { statusbar_update(); };
flamegraph_view->on_hover_change = [&] { statusbar_update(); };
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>(TRY("Filesystem events"_string)));
auto filesystem_events_tab = TRY(tab_widget->try_add_tab<GUI::Widget>("Filesystem events"_string));
TRY(filesystem_events_tab->try_set_layout<GUI::VerticalBoxLayout>(4));
auto filesystem_events_tree_view = TRY(filesystem_events_tab->try_add<GUI::TreeView>());