RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-29 16:47:45 +00:00
Code Issues Activity Actions

AK: Make "foo"_string infallible

Browse source 
Stop worrying about tiny OOMs.

Work towards #20405.
This commit is contained in:
Andreas Kling 2023-08-07 11:12:38 +02:00
parent db2a8725c6
commit 34344120f2
181 changed files with 626 additions and 630 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/ChessEngine/ChessEngine.cpp
View file

@ -13,8 +13,8 @@ using namespace Chess::UCI;
void ChessEngine::handle_uci()
{
send_command(IdCommand(IdCommand::Type::Name, "ChessEngine"_string.release_value_but_fixme_should_propagate_errors()));
send_command(IdCommand(IdCommand::Type::Author, "the SerenityOS developers"_string.release_value_but_fixme_should_propagate_errors()));
send_command(IdCommand(IdCommand::Type::Name, "ChessEngine"_string));
send_command(IdCommand(IdCommand::Type::Author, "the SerenityOS developers"_string));
send_command(UCIOkCommand());
}

2
Userland/Services/Taskbar/ShutdownDialog.cpp
View file

@ -65,7 +65,7 @@ ShutdownDialog::ShutdownDialog()
auto& right_container = content_container.add<GUI::Widget>();
right_container.set_layout<GUI::VerticalBoxLayout>(GUI::Margins { 12, 12, 8, 0 });
auto& label = right_container.add<GUI::Label>("What would you like to do?"_string.release_value_but_fixme_should_propagate_errors());
auto& label = right_container.add<GUI::Label>("What would you like to do?"_string);
label.set_text_alignment(Gfx::TextAlignment::CenterLeft);
label.set_fixed_height(22);
label.set_font(Gfx::FontDatabase::default_font().bold_variant());

2
Userland/Services/Taskbar/TaskbarWindow.cpp
View file

@ -110,7 +110,7 @@ void TaskbarWindow::add_system_menu(NonnullRefPtr<GUI::Menu> system_menu)
{
m_system_menu = move(system_menu);
m_start_button = GUI::Button::construct("Serenity"_string.release_value_but_fixme_should_propagate_errors());
m_start_button = GUI::Button::construct("Serenity"_string);
set_start_button_font(Gfx::FontDatabase::default_font().bold_variant());
m_start_button->set_icon_spacing(0);
auto app_icon = GUI::Icon::default_icon("ladyball"sv);

4
Userland/Services/WebServer/Client.cpp
View file

@ -116,7 +116,7 @@ ErrorOr<bool> Client::handle_request(HTTP::HttpRequest const& request)
if (Configuration::the().credentials().has_value()) {
bool has_authenticated = verify_credentials(request.headers());
if (!has_authenticated) {
auto const basic_auth_header = TRY("WWW-Authenticate: Basic realm=\"WebServer\", charset=\"UTF-8\""_string);
auto const basic_auth_header = "WWW-Authenticate: Basic realm=\"WebServer\", charset=\"UTF-8\""_string;
Vector<String> headers {};
TRY(headers.try_append(basic_auth_header));
TRY(send_error_response(401, request, move(headers)));
@ -325,7 +325,7 @@ ErrorOr<void> Client::handle_directory_listing(String const& requested_path, Str
auto response = builder.to_deprecated_string();
FixedMemoryStream stream { response.bytes() };
return send_response(stream, request, { .type = TRY("text/html"_string), .length = response.length() });
return send_response(stream, request, { .type = "text/html"_string, .length = response.length() });
}
ErrorOr<void> Client::send_error_response(unsigned code, HTTP::HttpRequest const& request, Vector<String> const& headers)

4
Userland/Services/WebServer/main.cpp
View file

@ -22,9 +22,9 @@
ErrorOr<int> serenity_main(Main::Arguments arguments)
{
static auto const default_listen_address = TRY("0.0.0.0"_string);
static auto const default_listen_address = "0.0.0.0"_string;
static auto const default_port = 8000;
static auto const default_document_root_path = TRY("/www"_string);
static auto const default_document_root_path = "/www"_string;
DeprecatedString listen_address = default_listen_address.to_deprecated_string();
int port = default_port;

2
Userland/Services/WindowServer/Window.cpp
View file

@ -708,7 +708,7 @@ void Window::request_update(Gfx::IntRect const& rect, bool ignore_occlusion)
void Window::ensure_window_menu()
{
if (!m_window_menu) {
m_window_menu = Menu::construct(nullptr, -1, "(Window Menu)"_string.release_value_but_fixme_should_propagate_errors());
m_window_menu = Menu::construct(nullptr, -1, "(Window Menu)"_string);
m_window_menu->set_window_menu_of(*this);
auto minimize_item = make<MenuItem>(*m_window_menu, (unsigned)WindowMenuAction::MinimizeOrUnminimize, "");